[release/7.0] Fix FailFast logging message #75718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
@eduardo-vp what branch are you trying to target? Do you want this change backported to RC2 or to GA?
|
|
@carlossanlop I think that GA is ok for this. |
|
Thanks @janvorli for the confirmation. Since this is GA, can one of you please fill the template, then send an email to Tactics for approval? |
|
Yes, @eduardo-vp will do that. |
jeffschwMSFT
approved these changes
Sep 16, 2022
mangod9
approved these changes
Sep 16, 2022
carlossanlop
added
Servicing-approved
|
Approved via email by Tactics. |
|
CI green. Approved and signed off. Ready to merge. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #75685 to release/7.0
/cc @eduardo-vp
Customer Impact
When the customer's app crashes due to an exception like access violation in an external native code, the customer doesn't get the crash address and error code in the event log entry (there is an
xinstead due to a bug). This change is a regression from .NET 6.Testing
A function in an external native code file with a memory access crash was used by a managed app. In the Event Viewer app it could be found the logs with the correct information.
Risk
Very low, this change only involves formatting character for the FormatMessage Windows API from a wrong one that doesn't format the values to a correct one and adds 0x prefix.