Skip to content

[release/7.0] Disable gen 1 budget accounting fix for segments #76412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2022
Merged

[release/7.0] Disable gen 1 budget accounting fix for segments #76412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/coreclr/gc/gc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21387,7 +21387,14 @@ void gc_heap::gc1()
dynamic_data* dd = hp->dynamic_data_of (gen);
dd_desired_allocation (dd) = desired_per_heap;
dd_gc_new_allocation (dd) = desired_per_heap;
#ifdef USE_REGIONS
// we may have had some incoming objects during this GC -
// adjust the consumed budget for these
dd_new_allocation (dd) = desired_per_heap - already_consumed_per_heap;
#else //USE_REGIONS
// for segments, we want to keep the .NET 6.0 behavior where we did not adjust
dd_new_allocation (dd) = desired_per_heap;
#endif //USE_REGIONS

if (gen == 0)
{
Expand Down Expand Up @@ -40425,9 +40432,14 @@ void gc_heap::compute_new_dynamic_data (int gen_number)
}
dd_gc_new_allocation (dd) = dd_desired_allocation (dd);

#ifdef USE_REGIONS
// we may have had some incoming objects during this GC -
// adjust the consumed budget for these
dd_new_allocation (dd) = dd_gc_new_allocation (dd) - in;
#else //USE_REGIONS
// for segments, we want to keep the .NET 6.0 behavior where we did not adjust
dd_new_allocation (dd) = dd_gc_new_allocation (dd);
#endif //USE_REGIONS
}

gen_data->pinned_surv = dd_pinned_survived_size (dd);
Expand Down