Skip to content

Make sure s_currentGenerationTable is safe for profiler attach #78841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2022
Merged

Make sure s_currentGenerationTable is safe for profiler attach #78841

merged 1 commit into from
Nov 28, 2022

Conversation

cshung
Copy link
Contributor

@cshung cshung commented Nov 24, 2022

No description provided.

@ghost ghost assigned cshung Nov 24, 2022
@ghost
Copy link

ghost commented Nov 24, 2022

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: cshung
Assignees: cshung
Labels:

area-Diagnostics-coreclr
Milestone: -

@cshung cshung marked this pull request as draft November 24, 2022 21:20
@cshung cshung linked an issue Nov 24, 2022 that may be closed by this pull request
net7.0 app crashes in ProfilerAddNewRegion after profiler attach #78831
Closed
@cshung cshung marked this pull request as ready for review November 25, 2022 00:29
@k15tfu k15tfu mentioned this pull request Nov 25, 2022
Closed
@tommcdon tommcdon requested a review from davmason November 28, 2022 19:05
tommcdon
tommcdon approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@tommcdon tommcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks! This is an important diagnostics scenario and so we should try to service this in 7.0 if possible.

@cshung cshung merged commit d1938dc into dotnet:main Nov 28, 2022
@cshung cshung deleted the public/generation_table_for_attach branch November 28, 2022 23:17
@cshung
Copy link
Contributor Author

cshung commented Nov 28, 2022

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3569480124

@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommcdon tommcdon tommcdon approved these changes

+1 more reviewer

@davmason davmason davmason approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@cshung cshung

Labels
area-Diagnostics-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

net7.0 app crashes in ProfilerAddNewRegion after profiler attach
3 participants
@cshung @davmason @tommcdon