JIT: Clean up some old style walks and QMARK validation #79747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted from early liveness PR. Also small visitor change.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsAlso a small visitor change. Extracted from #79346.
|
src/coreclr/jit/morph.cpp
Outdated
| // Returns true if a GT_QMARK node is encountered in the argx tree | ||
| // | ||
| if (comp->fgWalkTreePre(&argx, Compiler::fgChkQmarkCB) == Compiler::WALK_ABORT) | ||
| if (comp->gtTreeContainsOper(argx, GT_QMARK)) |
There was a problem hiding this comment.
Isn't this just dead code? All QMARKs should live in their own statements.
There was a problem hiding this comment.
Looks like it. Pushed some more clean up.
|
cc @dotnet/jit-contrib PTAL @TIHan |
jakobbotsch
changed the title
TIHan
approved these changes
Dec 16, 2022
BruceForstall
approved these changes
Dec 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also a small visitor change. Extracted from #79346.