Create source generator for configuration binding #82179
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| <Project> | ||
| <Target Name="_{TargetPrefix}GatherAnalyzers"> | ||
| <ItemGroup> | ||
| <_{TargetPrefix}Analyzer Include="@(Analyzer)" Condition="'%(Analyzer.NuGetPackageId)' == '{NuGetPackageId}'" /> | ||
| </ItemGroup> | ||
| </Target> | ||
layomia marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| <Target Name="_{TargetPrefix}RemoveAnalyzer" | ||
| Condition="'$({EnableSourceGeneratorPropertyName})' != 'true'" | ||
| AfterTargets="ResolvePackageDependenciesForBuild;ResolveNuGetPackageAssets" | ||
| DependsOnTargets="_{TargetPrefix}GatherAnalyzers"> | ||
|
|
||
| <ItemGroup> | ||
| <Analyzer Remove="@(_{TargetPrefix}Analyzer)" /> | ||
| </ItemGroup> | ||
| </Target> | ||
| </Project> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using Microsoft.CodeAnalysis; | ||
|
|
||
| namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration | ||
| { | ||
| internal abstract record CollectionSpec : TypeSpec | ||
| { | ||
| public CollectionSpec(ITypeSymbol type) : base(type) | ||
| { | ||
| IsReadOnly = type.IsReadOnly; | ||
| IsInterface = type is INamedTypeSymbol { TypeKind: TypeKind.Interface }; | ||
| } | ||
|
|
||
| public required TypeSpec ElementType { get; init; } | ||
|
|
||
| public bool IsReadOnly { get; } | ||
|
|
||
| public bool IsInterface { get; } | ||
|
|
||
| public CollectionSpec? ConcreteType { get; init; } | ||
| } | ||
|
|
||
| internal sealed record EnumerableSpec : CollectionSpec | ||
| { | ||
| public EnumerableSpec(ITypeSymbol type) : base(type) { } | ||
|
|
||
| public override TypeSpecKind SpecKind { get; init; } = TypeSpecKind.Enumerable; | ||
| } | ||
|
|
||
| internal sealed record DictionarySpec : CollectionSpec | ||
| { | ||
| public DictionarySpec(INamedTypeSymbol type) : base(type) { } | ||
|
|
||
| public override TypeSpecKind SpecKind => TypeSpecKind.Dictionary; | ||
|
There was a problem hiding this comment. nit: Should this be There was a problem hiding this comment. It depends: if it is converted into an auto-property then it will be part of the record's equality comparison implementation. FWIW the equality comparison generated for C# records does take polymorphism into account, so you wouldn't need to take the "kind" into account: |
||
|
|
||
| public required TypeSpec KeyType { get; init; } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.