Skip to content

[7.0] Fix superpmi_collect-setup.py helix images to use floating versions instead #83100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2023
Merged

[7.0] Fix superpmi_collect-setup.py helix images to use floating versions instead #83100

merged 2 commits into from
Mar 8, 2023

Conversation

carlossanlop
Copy link
Contributor

Per the suggestions here: #81712 (comment)

cc @sbomer @MattGal @mthalman

@carlossanlop carlossanlop added this to the 7.0.x milestone Mar 7, 2023
@carlossanlop carlossanlop self-assigned this Mar 7, 2023
@ghost
Copy link

ghost commented Mar 7, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Per the suggestions here: #81712 (comment)

cc @sbomer @MattGal @mthalman

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-Infrastructure
Milestone: 7.0.x

@carlossanlop carlossanlop mentioned this pull request Mar 7, 2023
Merged
sbomer
sbomer approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also update the comment at the top of the file. Thanks!

@carlossanlop
Copy link
Contributor Author

I'd also update the comment at the top of the file. Thanks!

Fixed, @sbomer.

@carlossanlop carlossanlop merged commit 2bc9b0a into release/7.0 Mar 8, 2023
@carlossanlop carlossanlop deleted the UseFloatingImageVersions branch March 8, 2023 05:31
@ghost ghost locked as resolved and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbomer sbomer sbomer approved these changes

@MattGal MattGal MattGal approved these changes

@mthalman mthalman mthalman approved these changes

@ViktorHofer ViktorHofer Awaiting requested review from ViktorHofer

@ericstj ericstj Awaiting requested review from ericstj

@hoyosjs hoyosjs Awaiting requested review from hoyosjs

Assignees

@carlossanlop carlossanlop

Labels
area-Infrastructure
Projects
None yet
Milestone
7.0.x
Development

Successfully merging this pull request may close these issues.
4 participants
@carlossanlop @sbomer @MattGal @mthalman