-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Delete GT_OBJ
#84221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete GT_OBJ
#84221
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsAt this point, both There will be a follow-up which similarly unifies
|
1aa3b80
to
1383ff5
Compare
@dotnet/jit-contrib |
983db5d
to
6ba7292
Compare
GT_OBJ and GT_OBJ both represent struct loads. There is no need to have two. Delete GT_OBJ as the more derived one.
6ba7292
to
172bd11
Compare
172bd11
to
c0fbd99
Compare
@SingleAccretion can you resolve the conflicts? |
@dotnet/jit-contrib anyone planning on reviewing this one? I will take a look if there are not volunteers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
blkNode->gtFlags |= indirFlags; | ||
blkNode->SetIndirExceptionFlags(this); | ||
|
||
// TODO-Bug: this method does not have enough information to make this determination. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a follow-up issue for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that comment just migrated here from the former OBJ case.
- Failed due to dotnet#84221
At this point, both
GT_BLK
andGT_OBJ
represent struct loads and are essentially identical in purpose (if not functionality). This change unifies the two asGT_BLK
, though I am naturally open to going the other way or choosing a different oper name altogether.There will be a follow-up which similarly unifies
STORE_BLK
withSTORE_OBJ
.Diffs: one CSE due to the change in
gtSetEvalOrder
.A bit of a TP regression on 64 bit because MSVC doesn't inline
gtIsLikelyRegVar
in the same function, and some perturbance in theswitch
offgComputeLifeLIR
.TP breakdown