Shuffle some MethodTable flags
#85634
Conversation
* `IDynamicInterfaceCastableFlag` cannot be set on types that have a component size, so move it from the valuable location in `Flags` to `FlagsEx`. * Move `HasSealedVTableEntriesFlag` from rare flags to flags. This flag is not so rare. All async state machine types set it, for example. * Delete `IsAbstractClassFlag`. This was introduce in .NET Native for `GetUninitializedObject` since accessing `Type.IsAbstract` could trigger a `MissingMetadataException` there. We got rid of that concept in NativeAOT because it cannot be reconciled with ILLink trimming. Rewrite the code to use `Type.IsAbstract`. Saves 15 kB on BasicMinimalApis, which is nice. Also makes things faster since we avoid reading optional fields and rare flags.
ghost
assigned
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue Details
Saves 15 kB on BasicMinimalApis, which is nice. Also makes things faster since we avoid reading optional fields and rare flags. Cc @dotnet/ilc-contrib
|
| if (type.IsCOMObject) | ||
| { | ||
| throw new NotSupportedException(SR.NotSupported_ManagedActivation); | ||
| } |
There was a problem hiding this comment.
(Unrelated to this PR)
We are missing a check for function pointers here. Could you please fix it in a follow up?
There was a problem hiding this comment.
Activator.CreateInstance seems to be missing it too.
There was a problem hiding this comment.
Not close to a computer now but I think Activator should be fine because there's no constructor to run and they're not a valuetype. I don't see it handling pointers either.
2 participants
IDynamicInterfaceCastableFlagcannot be set on types that have a component size, so move it from the valuable location inFlagstoFlagsEx.HasSealedVTableEntriesFlagfrom rare flags to flags. This flag is not so rare. All async state machine types set it, for example.IsAbstractClassFlag. This was introduce in .NET Native forGetUninitializedObjectsince accessingType.IsAbstractcould trigger aMissingMetadataExceptionthere. We got rid of that concept in NativeAOT because it cannot be reconciled with ILLink trimming. Rewrite the code to useType.IsAbstract.Saves 15 kB on BasicMinimalApis, which is nice. Also makes things faster since we avoid reading optional fields and rare flags.
Cc @dotnet/ilc-contrib