Skip to content

[RISC-V] Fix emitOutputInstr #86078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2023
Merged

[RISC-V] Fix emitOutputInstr #86078

merged 1 commit into from
May 12, 2023

Conversation

clamp03
Copy link
Member

@clamp03 clamp03 commented May 11, 2023

  • Fix to use instruction code not INS_

@clamp03
[RISC-V] Fix emitOutputInstr
457133f 
- Fix to use instruction code not INS_
@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels May 11, 2023
@ghost
Copy link

ghost commented May 11, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Fix to use instruction code not INS_
Author: clamp03
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@clamp03
Copy link
Member Author

clamp03 commented May 11, 2023

Part of #84834

@clamp03
Copy link
Member Author

clamp03 commented May 12, 2023

@jkotas @jakobbotsch I do not think the test failures are due to this PR. Could you review and merge? Thank you very much.

@clamp03 clamp03 mentioned this pull request May 12, 2023
Open
7 tasks
@jakobbotsch
Copy link
Member

The failures were #86082

@jakobbotsch jakobbotsch merged commit 0c423af into dotnet:main May 12, 2023
@am11 am11 added the arch-riscv Related to the RISC-V architecture label May 13, 2023
@clamp03 clamp03 deleted the fixoutputinstr branch May 30, 2023 08:32
@ghost ghost locked as resolved and limited conversation to collaborators Jun 29, 2023
@clamp03 clamp03 self-assigned this Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

+1 more reviewer

@gbalykov gbalykov gbalykov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@clamp03 clamp03

Labels
arch-riscv Related to the RISC-V architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clamp03 @jakobbotsch @gbalykov @am11