Skip to content

[RISC-V] Missing defines in GC #88661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2023
Merged

[RISC-V] Missing defines in GC #88661

merged 1 commit into from
Jul 12, 2023

Conversation

alpencolt
Copy link

Some defines were not ported to RISC-V in GC. This PR fix it.

Part of #84834

cc @jakobbotsch @wscho77 @HJLeee @JongHeonChoi @t-mustafin @clamp03 @gbalykov

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-GC-coreclr labels Jul 11, 2023
@ghost
Copy link

ghost commented Jul 11, 2023

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

Some defines were not ported to RISC-V in GC. This PR fix it.

Part of #84834

cc @jakobbotsch @wscho77 @HJLeee @JongHeonChoi @t-mustafin @clamp03 @gbalykov

Author: alpencolt
Assignees: -
Labels:

area-GC-coreclr, community-contribution
Milestone: -

This was referenced Jul 11, 2023
Closed
Closed
@clamp03 clamp03 added the arch-riscv Related to the RISC-V architecture label Jul 11, 2023
gbalykov
gbalykov reviewed Jul 12, 2023
View reviewed changes
@alpencolt alpencolt force-pushed the risc-v-missing-defines-gc branch from 69d50d8 to eae024d Compare July 12, 2023 16:47
This was referenced Jul 12, 2023
Closed
Closed
Closed
Closed
@mangod9
Copy link
Member

mangod9 commented Jul 12, 2023

CI failures appear to be known issues.

@mangod9 mangod9 closed this Jul 12, 2023
@mangod9 mangod9 reopened this Jul 12, 2023
@mangod9 mangod9 merged commit a23c7a1 into dotnet:main Jul 12, 2023
@build-analysis build-analysis bot mentioned this pull request Jul 13, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mangod9 mangod9 mangod9 approved these changes

+2 more reviewers

@gbalykov gbalykov gbalykov approved these changes

@t-mustafin t-mustafin t-mustafin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alpencolt alpencolt

Labels

arch-riscv Related to the RISC-V architecture area-GC-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alpencolt @mangod9 @gbalykov @t-mustafin @clamp03