[browser] detect and assert engine features #88846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
ghost
added
the
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kg
approved these changes
Jul 13, 2023
maraf
reviewed
Jul 14, 2023
| const emptyBuffer = new Uint8Array(); | ||
|
|
||
| function verifyEnvironment() { | ||
| if (ENVIRONMENT_IS_SHELL) { |
There was a problem hiding this comment.
Shoud we move it after the typeof globalThis.WebSocket !== "function" condition?
There was a problem hiding this comment.
for some random polyfill ? I don't think so.
There was a problem hiding this comment.
Yes, for some polyfill, or if it happens to be added... What is the reason to be that restrictive?
There was a problem hiding this comment.
It has complex dynamic behavior and even the nodeJS polyfill doen't work well in all use-cases. I'm just loud and clear this is not supported.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fail fast during startup, if we don't have necessary JS APIs.
Contributes to #84574
Contributes to #76961