Skip to content

[browser] fix NodeJS fetch detection #89393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2023
Merged

[browser] fix NodeJS fetch detection #89393

merged 1 commit into from
Jul 25, 2023

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jul 24, 2023 •
edited
Loading

Fixes #88900

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm labels Jul 24, 2023
@pavelsavara pavelsavara added this to the 8.0.0 milestone Jul 24, 2023
@pavelsavara pavelsavara requested a review from maraf July 24, 2023 16:12
@pavelsavara pavelsavara requested a review from lewing as a code owner July 24, 2023 16:12
@pavelsavara pavelsavara self-assigned this Jul 24, 2023
@pavelsavara pavelsavara requested a review from kg as a code owner July 24, 2023 16:12
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 24, 2023
@ghost
Copy link

ghost commented Jul 24, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #88900

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, os-browser
Milestone: 8.0.0

@pavelsavara pavelsavara added area-System.Net.Http and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 24, 2023
@ghost
Copy link

ghost commented Jul 24, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #88900

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Net.Http, needs-area-label, os-browser
Milestone: 8.0.0

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Jul 24, 2023
Closed
ilonatommy
ilonatommy approved these changes Jul 25, 2023
View reviewed changes
@pavelsavara pavelsavara merged commit 1bfd46d into dotnet:main Jul 25, 2023
@build-analysis build-analysis bot mentioned this pull request Jul 25, 2023
Closed
This was referenced Jul 26, 2023
Closed
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Aug 24, 2023
@pavelsavara pavelsavara deleted the browser_has_fetch branch September 2, 2024 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilonatommy ilonatommy ilonatommy approved these changes

@maraf maraf Awaiting requested review from maraf

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@kg kg Awaiting requested review from kg

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Net.Http os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

[browser][nodejs] RequestDuration_CustomTags_Recorded - ENOENT: no such file or directory, open 'http://127.0.0.1:45051/'
2 participants
@pavelsavara @ilonatommy