Skip to content

Activate Quic Alpn Narrowing Test #91116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 4, 2023
Merged

Activate Quic Alpn Narrowing Test #91116

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
38d6220
Delete ActiveIssue
liveans Aug 25, 2023
6b98b42
Disable Not Existing Inline Data
liveans Aug 26, 2023
7514f14
Delete connection accept
liveans Aug 26, 2023
302a2a0
Merge assert and variable
liveans Aug 26, 2023
d12cc4d
Add listener throws case
liveans Aug 27, 2023
3ebe176
Update src/libraries/System.Net.Quic/tests/FunctionalTests/QuicListen…
liveans Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/libraries/System.Net.Quic/tests/FunctionalTests/QuicListenerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,6 @@ public async Task Listener_AlpnNarrowingDown_Success()
Assert.Equal(new SslApplicationProtocol("test"), clientConnection2.NegotiatedApplicationProtocol);
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/86701")]
[Theory]
[InlineData("foo")]
[InlineData("not_existing")]
Expand Down Expand Up @@ -503,15 +502,18 @@ public async Task Listener_AlpnNarrowingDown_Failure(string alpn)
return ValueTask.FromResult(options);
}
};
bool isAlpnPresentOnInitialAlpnList = listenerOptions.ApplicationProtocols.Contains(new SslApplicationProtocol(alpn)); // If the ALPN is not present on initial list, AcceptConnectionAsync will not throw AuthenticationException.
await using QuicListener listener = await CreateQuicListener(listenerOptions);

QuicClientConnectionOptions clientOptions = CreateQuicClientOptions(listener.LocalEndPoint);
clientOptions.ClientAuthenticationOptions.ApplicationProtocols = new()
{
new SslApplicationProtocol(alpn),
};
ValueTask<QuicConnection> connectTask = CreateQuicConnection(clientOptions);
await Assert.ThrowsAsync<AuthenticationException>(() => listener.AcceptConnectionAsync().AsTask().WaitAsync(timeoutToken));
if (isAlpnPresentOnInitialAlpnList)
{
await Assert.ThrowsAsync<AuthenticationException>(() => listener.AcceptConnectionAsync().AsTask().WaitAsync(timeoutToken));
}
await Assert.ThrowsAsync<AuthenticationException>(() => connectTask.AsTask().WaitAsync(timeoutToken));
}
}
Expand Down