Skip to content

Ensure HW intrinsics enabled when running arm64 longmul tests. #92607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2023
Merged

Ensure HW intrinsics enabled when running arm64 longmul tests. #92607

merged 1 commit into from
Sep 26, 2023

Conversation

c272
Copy link
Contributor

@c272 c272 commented Sep 25, 2023 •
edited by kunalspathak
Loading

Currently, when jitstress runs the HWIntrinsics disabled environment for JIT opts, arm64 longmul tests will fall over as it must have hardware intrinsics enabled to detect the correct assembly output (as per #92571).

This patch simply forces on DOTNET_EnableHWIntrinsic to ensure the test will always function correctly. I'm not sure this is a complete solution to the problem (not sure what category this test should be in, and I'm not familiar enough with the HWIntrinsics test templating to move it to there quickly if need be), but this should work.

Let me know what you think.
cc: @kunalspathak

Fixes: #92571

@c272
Ensure HW intrinsics enabled when running arm64 longmul tests.
3ab1f7e 
Currently, when jitstress runs the HWIntrinsics disabled environment
for JIT opts, this test will fall over as it must have hardware
intrinsics enabled to detect the correct assembly output.

This patch simply forces on DOTNET_EnableHWIntrinsic to ensure the
test will always function correctly.
@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Sep 25, 2023
@ghost
Copy link

ghost commented Sep 25, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Currently, when jitstress runs the HWIntrinsics disabled environment for JIT opts, arm64 longmul tests will fall over as it must have hardware intrinsics enabled to detect the correct assembly output (as per #92571).

This patch simply forces on DOTNET_EnableHWIntrinsic to ensure the test will always function correctly. I'm not sure this is a complete solution to the problem (not sure what category this test should be in, and I'm not familiar enough with the HWIntrinsics test templating to move it to there quickly if need be), but this should work.

Let me know what you think.
cc: @kunalspathak

Author: c272
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@c272 c272 mentioned this pull request Sep 25, 2023
Closed
@kunalspathak
Copy link
Contributor

/azp run runtime-coreclr jitstress-isas-arm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@c272 c272 mentioned this pull request Sep 26, 2023
Closed
@c272
Copy link
Contributor Author

c272 commented Sep 26, 2023 •
edited
Loading

Doesn't look like the test failures here are the fault of this patch? Only failures seem to be in readytorun.

@kunalspathak
Copy link
Contributor

Failure seems related to #92572.

kunalspathak
kunalspathak approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunalspathak kunalspathak merged commit 500d0ac into dotnet:main Sep 26, 2023
@c272 c272 deleted the longmul-tests branch September 26, 2023 15:21
@ghost ghost locked as resolved and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kunalspathak kunalspathak kunalspathak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test failure: JIT/opt/Multiply/MultiplyLongOps/MultiplyLongOps.cmd

2 participants

@c272 @kunalspathak