Small cleanup for Lock in Mono #94275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Used the project property instead of disabling the compiler warning. Probably a bit cleaner, and would enable using Lock in other libraries to try it out. - Undid an unnecessary change from #87672
jkotas
reviewed
Nov 1, 2023
|
|
||
| <EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles> | ||
|
|
||
| <!-- CA2252: Opt in to preview features before using them (Lock) --> |
There was a problem hiding this comment.
Should it rather be in the shared src\libraries\System.Private.CoreLib\src\System.Private.CoreLib.Shared.projitems?
There was a problem hiding this comment.
That would work better, updated
jkotas
reviewed
Nov 2, 2023
| <StringResourcesName Condition="'$(StringResourcesName)' == ''">System.Private.CoreLib.Strings</StringResourcesName> | ||
| <GenerateResourcesSubstitutions>true</GenerateResourcesSubstitutions> | ||
|
|
||
| <!-- CA2252: Opt in to preview features before using them (for System.Threading.Lock) --> |
There was a problem hiding this comment.
You can also delete CA2252 pragmas from under src/libraries/System.Private.CoreLib
There was a problem hiding this comment.
jkotas
approved these changes
Nov 2, 2023
This was referenced Nov 2, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locktype in preview mode #87672