Skip to content

[release/8.0] Update dependencies from dotnet/arcade #94792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 16, 2023
Merged

[release/8.0] Update dependencies from dotnet/arcade #94792

merged 3 commits into from
Nov 16, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 2fb9f077-51f0-474b-0ead-08db9e40a4f0
  • Build: 20231114.4
  • Date Produced: November 14, 2023 7:29:21 PM UTC
  • Commit: 0aaeafef60933f87b0b50350313bb2fd77defb5d
  • Branch: refs/heads/release/8.0
  • Updates to .NET SDKs:
    • Updates sdk.version to 8.0.100
    • Updates tools.dotnet to 8.0.100

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20231…
671d42a 
…114.4

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23556.5 -> To Version 8.0.0-beta.23564.4
@ghost ghost added the area-codeflow for labeling automated codeflow label Nov 15, 2023
@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Nov 15, 2023
This was referenced Nov 15, 2023
Closed
Closed
@carlossanlop
Copy link
Contributor

carlossanlop commented Nov 15, 2023 •
edited
Loading

I'm seeing a failure that I have not seen before, so I'm unsure if it's related to this PR. Today is Code Complete, can someone from @dotnet/runtime-infrastructure look at this issue?

 Processing C:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\um\ocidl.acf
  
  ocidl.acf
  
  waiting for D:/a/_work/1/s/artifacts/obj/win-x64.Release/corehost/test/typelibs\dlldata.c ...
  
  ninja: build stopped: subcommand failed.
  Failed to generate native component build project!
D:\a\_work\1\s\src\native\corehost\corehost.proj(159,5): error MSB3073: The command ""D:\a\_work\1\s\src\native\corehost\build.cmd" Release x64 commit 98214d9fcdb49c32d7d9670a103e1dd809c42dfc outputrid win-x64 portable incremental-native-build rootdir D:\a\_work\1\s\ runtimeflavor CoreCLR runtimeconfiguration Debug" exited with code 1.

NativeAOT leg https://dev.azure.com/dnceng-public/public/_build/results?buildId=471036&view=logs&j=15d34cf8-8614-5f8a-e364-3c281b6c41dd&t=9ddf4123-b773-5dc1-2b69-29721ec5c0a1&l=2714

@carlossanlop
Copy link
Contributor

Also windows arm64:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=471036&view=logs&j=e6d4132d-ca66-516d-d04c-739c69ef2034&t=7ba006bf-65d2-5955-807e-af3c6a17635f

 [190/206] Building CXX object ijwhost\CMakeFiles\ijwhost.dir\ijwthunk.cpp.obj
  ninja: build stopped: subcommand failed.
  Failed to generate native component build project!
D:\a\_work\1\s\src\native\corehost\corehost.proj(159,5): error MSB3073: The command ""D:\a\_work\1\s\src\native\corehost\build.cmd" Debug arm64 commit 98214d9fcdb49c32d7d9670a103e1dd809c42dfc outputrid win-arm64 portable incremental-native-build rootdir D:\a\_work\1\s\ runtimeflavor coreclr runtimeconfiguration release" exited with code 1.
##[error]src\native\corehost\corehost.proj(159,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command ""D:\a\_work\1\s\src\native\corehost\build.cmd" Debug arm64 commit 98214d9fcdb49c32d7d9670a103e1dd809c42dfc outputrid win-arm64 portable incremental-native-build rootdir D:\a\_work\1\s\ runtimeflavor coreclr runtimeconfiguration release" exited with code 1.

Build FAILED.

@carlossanlop
Copy link
Contributor

The Quic test failure has been fixed in staging. It should go away after I flow staging to internal.
https://dev.azure.com/dnceng-public/public/_build/results?buildId=471036&view=logs&j=fd49b2ea-3ee3-5298-d793-bdb9fd631e7e&t=26d44400-a1b8-5ed1-d719-0cc35b38251b

@carlossanlop
Set MicrosoftDotnetSdkInternalVersion to 8.0.100.
182a073 
Uncomment SdkVersionForWorkloadTesting line.
@carlossanlop carlossanlop mentioned this pull request Nov 16, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request Nov 16, 2023
Closed
@ViktorHofer
Copy link
Member 

FAILED: Interop/IJW/NativeVarargs/CMakeFiles/IjwNativeVarargs.dir/IjwNativeVarargs.cpp.obj 
C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1437~1.328\bin\Hostx86\x64\cl.exe  /nologo /TP -DBUILDENV_DEBUG=1 -DDEBUG -DHOST_64BIT -DHOST_AMD64 -DHOST_WINDOWS -DIjwNativeVarargs_EXPORTS -DTARGET_64BIT -DTARGET_AMD64 -DTARGET_WINDOWS -DURTBLDENV_FRIENDLY=Debug -DWINDOWS -D_DBG -D_DEBUG -D_FILE_OFFSET_BITS=64 -ID:\a\_work\1\s\src\native -ID:\a\_work\1\s\src\tests\Interop\common -ID:\a\_work\1\s\src\tests\Common\Platform /DWIN32 /D_WINDOWS     /Zi /Ob0 /Od   -MDd /Od /nologo /W4 /WX /Oi /Oy- /Gm- /Zp8 /Gy /GS /fp:precise /FC /MP /Zm200 /Zc:strictStrings /Zc:wchar_t /Zc:inline /Zc:forScope /wd4065 /wd4100 /wd4127 /wd4131 /wd4189 /wd4200 /wd4201 /wd4206 /wd4239 /wd4245 /wd4291 /wd4310 /wd4324 /wd4366 /wd4456 /wd4457 /wd4458 /wd4459 /wd4463 /wd4505 /wd4702 /wd4706 /wd4733 /wd4815 /wd4838 /wd4918 /wd4960 /wd4961 /wd5105 /wd5205 /we4007 /we4013 /we4102 /we4551 /we4700 /we4640 /we4806 /w34092 /w34121 /w34125 /w34130 /w34132 /w34212 /w34530 /w35038 /w44177 /Zi /ZH:SHA_256 /source-charset:utf-8 /homeparams -wd4100 -wd4244 -wd4514 -wd4625 -wd4626 -wd4668 -wd4710 -wd4711 -wd4774 -wd4820 -wd5025 -wd5026 -wd5027 -wd5039 /EHa /wd4365 /wd4679 /wd5271 /clr:netcore /AID:\a\_work\1\s\.dotnet/packs/Microsoft.NETCore.App.Ref/8.0.0/ref/net8.0 /showIncludes /FoInterop\IJW\NativeVarargs\CMakeFiles\IjwNativeVarargs.dir\IjwNativeVarargs.cpp.obj /FdInterop\IJW\NativeVarargs\CMakeFiles\IjwNativeVarargs.dir\ /FS -c D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(141): error C3611: 'System::Numerics::INumberBase::System::IUtf8SpanFormattable.TryFormat': a sealed function cannot have a pure-specifier
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(141): note: This diagnostic occurred while importing type 'System::Numerics::INumberBase' from assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(141): note: This diagnostic occurred while importing type 'System::Numerics::INumber' from assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(141): note: This diagnostic occurred while importing type 'System::Numerics::IBinaryNumber' from assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(141): note: This diagnostic occurred while importing type 'System::Numerics::IBinaryInteger' from assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(141): note: This diagnostic occurred while importing type 'System::Int32' from assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(141): error C3611: 'System::Numerics::INumberBase<TSelf>::System::IUtf8SpanFormattable.TryFormat': a sealed function cannot have a pure-specifier
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(141): note: see reference to class generic instantiation 'System::Numerics::INumberBase<TSelf>' being compiled
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(141): note: This diagnostic occurred while importing type 'System::Numerics::INumber' from assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(141): note: This diagnostic occurred while importing type 'System::Numerics::IBinaryNumber' from assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(141): note: This diagnostic occurred while importing type 'System::Numerics::IBinaryInteger' from assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(141): note: This diagnostic occurred while importing type 'System::Int32' from assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(141): error C3611: 'System::Numerics::INumberBase<int>::System::IUtf8SpanFormattable.TryFormat': a sealed function cannot have a pure-specifier
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(141): note: see reference to class generic instantiation 'System::Numerics::INumberBase<int>' being compiled
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(141): note: see reference to class generic instantiation 'System::Numerics::INumber<int>' being compiled
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(141): note: see reference to class generic instantiation 'System::Numerics::IBinaryNumber<int>' being compiled
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(141): note: see reference to class generic instantiation 'System::Numerics::IBinaryInteger<int>' being compiled
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(141): note: This diagnostic occurred while importing type 'System::Int32' from assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(394): error C3611: 'System::Numerics::INumberBase<short>::System::IUtf8SpanFormattable.TryFormat': a sealed function cannot have a pure-specifier
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(394): note: see reference to class generic instantiation 'System::Numerics::INumberBase<short>' being compiled
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(394): note: see reference to class generic instantiation 'System::Numerics::INumber<short>' being compiled
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(394): note: see reference to class generic instantiation 'System::Numerics::IBinaryNumber<short>' being compiled
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(394): note: see reference to class generic instantiation 'System::Numerics::IBinaryInteger<short>' being compiled
D:\a\_work\1\s\src\tests\Interop\IJW\NativeVarargs\IjwNativeVarargs.cpp(394): note: This diagnostic occurred while importing type 'System::Int16' from assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
[247/367] Building C object JIT\Directed\StructABI\CMakeFiles\StructABILib.dir\StructABI.c.obj
[248/367] Linking CXX shared library Interop\COM\ComWrappers\MockReferenceTrackerRuntime\MockReferenceTrackerRuntime.dll
[249/367] Linking CXX shared library Interop\COM\ComWrappers\WeakReference\WeakReferenceNative.dll
[250/367] Linking CXX shared library JIT\Directed\Convert\out_of_range_fp_to_int_conversionsnative.dll
[251/367] Linking CXX shared library Interop\IJW\ijwhostmock\ijwhost.dll
ninja: build stopped: subcommand failed.
BUILDTEST: Error: native test build failed.

@tannergooding @agocke PTAL

@ViktorHofer ViktorHofer merged commit aab2b2e into release/8.0 Nov 16, 2023
@ViktorHofer ViktorHofer deleted the darc-release/8.0-39c47286-350d-4f0c-8f49-2c3ac34398c2 branch November 16, 2023 13:35
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

+1 more reviewer

@carlossanlop carlossanlop carlossanlop approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow Servicing-approved Approved for servicing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlossanlop @ViktorHofer