Skip to content

Fix Scalar.Abs for TInteger.MinValue #95597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 6, 2023
Merged

Fix Scalar.Abs for TInteger.MinValue #95597

merged 2 commits into from
Dec 6, 2023

Conversation

MichalPetryka
Copy link
Contributor

Fixes #95592.

@ghost ghost added area-Codegen-Intrinsics-mono community-contribution Indicates that the PR has been added by a community member labels Dec 4, 2023
@ghost
Copy link

ghost commented Dec 4, 2023

Tagging subscribers to this area: @SamMonoRT, @fanyang-mono
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #95592.

Author: MichalPetryka
Assignees: -
Labels:

area-Codegen-Intrinsics-mono
Milestone: -

stephentoub
stephentoub reviewed Dec 4, 2023
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you add some tests as well?

@MichalPetryka
Copy link
Contributor Author

Could you add some tests as well?

Is the test you've added in the repro check PR okay here? Scalar<T> isn't a public API (at least yet) so I can't test it directly.

@stephentoub
Copy link
Member

I think that or simple variations of it (i.e. testing via Vector128/256/512) would be fine.

stephentoub
stephentoub approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephentoub stephentoub merged commit 42255ea into dotnet:main Dec 6, 2023
@kotlarmilos kotlarmilos mentioned this pull request Dec 12, 2023
Closed
@EgorBo EgorBo mentioned this pull request Dec 14, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-Codegen-Intrinsics-mono community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mono's Vector128 support incorrectly handles Abs for signed integer MinValue
2 participants
@MichalPetryka @stephentoub