Skip to content

[RISC-V] Fix the order of parameters stored on the stack #96106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 45 commits into from
Dec 17, 2023
Merged

[RISC-V] Fix the order of parameters stored on the stack #96106

merged 45 commits into from
Dec 17, 2023

Conversation

Xinlong-Wu
Copy link
Contributor

This Patch implement following things:

  • Fix the order of parameters stored on the stack
  • Fix restoring of lmf & ctx
  • decompose, lowering, output more inst
  • implement mono_arch_get_call_filter
  • correct MAX_ARCH_DELEGATE_PARAMS

now Mono risc-v can run programs in following list:
https://github.com/Xinlong-Wu/runtime/blob/riscv-jit-rv64/RISCV64-PORTING.md

@Xinlong-Wu
tmp
40c5c9a
@Xinlong-Wu
fix ArgVtypeByRef
c824845
@Xinlong-Wu
update
031d81a
@Xinlong-Wu
OP_VCALL2_REG
e2765c0
@Xinlong-Wu
update
524004b
@Xinlong-Wu
update
9749c3a
@Xinlong-Wu
fix OP_ZEXT_
963f0c8
@Xinlong-Wu
OP_RCLT_UN & OP_ICONV_TO_OVF_U1
38b7707
@Xinlong-Wu
fix save lmf
f20a8d8
@Xinlong-Wu
fix type of imm param in load/store
52dd19f
@Xinlong-Wu
mono_arch_get_rethrow_exception & mono_arch_get_rethrow_preserve_exce…
7dbcd1a 
…ption
@Xinlong-Wu
skip non callee saved regs when unwind frame
0164141
@Xinlong-Wu
fix cfa
7617c67
@Xinlong-Wu
update porting ststus
2fc5dfa
@Xinlong-Wu
lowering & output fcall_reg
9118cf3 
decompose F/RCONV_TO_OVF_I8, OP_LCONV_TO_OVF_U*
@Xinlong-Wu
update
9b44a3e
@Xinlong-Wu
update
cbfe4c4
@Xinlong-Wu
update
f21d0cb
@Xinlong-Wu
fix mono_arch_emit_outarg_vt for type ArgVtypeInMixed
3ea947b
@Xinlong-Wu
update
4d953a6
@Xinlong-Wu
unsolved roslyn-sdk
9efa4cf
@Xinlong-Wu
call_filter
7c19df3 
OP_ICONV_TO_OVF_U8 & OP_LSUB_OVF & OP_LMUL_OVF
OP_SUBCC & OP_LSUBCC
@Xinlong-Wu
fix OP_ADDCC
7487063
@Xinlong-Wu
update
a79c891
@Xinlong-Wu
voidcall_membase, mono_arch_get_call_filter
666ef35
@Xinlong-Wu
fix stack usage of Call param with OnStack type
f150a6b
@Xinlong-Wu
fix stack alloc for freg
de49df3
@Xinlong-Wu
tmp
cb54ef5
@Xinlong-Wu
tmp
50a82b6
@Xinlong-Wu
update
470bdc5
@ghost ghost added area-VM-meta-mono community-contribution Indicates that the PR has been added by a community member labels Dec 17, 2023
@am11 am11 added the arch-riscv Related to the RISC-V architecture label Dec 17, 2023
@am11
Copy link
Member

am11 commented Dec 17, 2023

Great progress! You could also try running mono-flavored runtime tests: https://github.com/dotnet/runtime/blob/main/docs/workflow/testing/mono/testing.md#desktop-mono and track the progress in an issue (similar to the one for coreclr #84834).

@vargaz vargaz merged commit 447f78e into dotnet:main Dec 17, 2023
@Xinlong-Wu Xinlong-Wu mentioned this pull request Dec 18, 2023
Open
7 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageek lambdageek Awaiting requested review from lambdageek

1 more reviewer

@vargaz vargaz vargaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

arch-riscv Related to the RISC-V architecture area-VM-meta-mono community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Xinlong-Wu @am11 @vargaz