Skip to content

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jan 4, 2024

  • fixed CaptureContextFromParameter and SealJSImportCapturing
  • new test JSObject_CapturesAffinity
  • fixed ExecutorType.NewThread in tests
  • cleanup
  • postpone possible async and background jobs on the UI thread until at least one available threads is loaded into emscripten pool in schedule_background_exec and mono_wasm_invoke_import_async

- new test JSObject_CapturesAffinity
- fixed ExecutorType.NewThread in tests
- cleanup
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Jan 4, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Jan 4, 2024
@pavelsavara pavelsavara requested review from kg and maraf January 4, 2024 19:07
@pavelsavara pavelsavara self-assigned this Jan 4, 2024
@ghost
Copy link

ghost commented Jan 4, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • fixed CaptureContextFromParameter and SealJSImportCapturing
  • new test JSObject_CapturesAffinity
  • fixed ExecutorType.NewThread in tests
  • cleanup
Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser

Milestone: 9.0.0

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kg
Copy link
Member

kg commented Jan 4, 2024

looks good so far

@pavelsavara pavelsavara marked this pull request as ready for review January 4, 2024 19:35
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

… least one available threads is loaded into emscripten pool
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

All CI failures are known

@pavelsavara pavelsavara merged commit 445c4a0 into dotnet:main Jan 6, 2024
@pavelsavara pavelsavara deleted the browser_jsimport_fix_dispatch branch January 6, 2024 15:59
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants