Skip to content

[mono][amd64] Fix Vector128 relational comparison API's for nuint type #96515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 8, 2024
Merged

[mono][amd64] Fix Vector128 relational comparison API's for nuint type #96515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b83a14
Fix uint greatetThan
fanyang-mono Jan 4, 2024
872aa41
Enable disabled tests
fanyang-mono Jan 5, 2024
6a73791
Add a new test
fanyang-mono Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/libraries/System.Numerics.Tensors/tests/TensorPrimitivesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1411,7 +1411,6 @@ public void MaxMagnitude_Tensor_ThrowsForEmpty()
Assert.Throws<ArgumentException>(() => MaxMagnitude(ReadOnlySpan<T>.Empty));
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/96443", TestRuntimes.Mono)]
[Fact]
public void MaxMagnitude_Tensor()
{
Expand Down Expand Up @@ -1483,7 +1482,6 @@ public void MaxMagnitude_Tensor_Negative0LesserThanPositive0()
Assert.Equal(ConvertFromSingle(1), MaxMagnitude( [ConvertFromSingle(-0f), ConvertFromSingle(-0f), ConvertFromSingle(-0f), ConvertFromSingle(-0f), ConvertFromSingle(-1), ConvertFromSingle(-0f), ConvertFromSingle(0f), ConvertFromSingle(1)]));
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/96443", TestRuntimes.Mono)]
[Fact]
public void MaxMagnitude_TwoTensors()
{
Expand All @@ -1502,7 +1500,6 @@ public void MaxMagnitude_TwoTensors()
});
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/96443", TestRuntimes.Mono)]
[Fact]
public void MaxMagnitude_TwoTensors_InPlace()
{
Expand Down Expand Up @@ -1531,7 +1528,6 @@ public void MaxMagnitude_TwoTensors_InPlace()
});
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/96443", TestRuntimes.Mono)]
[Fact]
public void MaxMagnitude_TwoTensors_SpecialValues()
{
Expand Down Expand Up @@ -1789,7 +1785,6 @@ public void MinMagnitude_Tensor_ThrowsForEmpty()
Assert.Throws<ArgumentException>(() => MinMagnitude(ReadOnlySpan<T>.Empty));
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/96443", TestRuntimes.Mono)]
[Fact]
public void MinMagnitude_Tensor()
{
Expand Down Expand Up @@ -1859,7 +1854,6 @@ public void MinMagnitude_Tensor_Negative0LesserThanPositive0()
Assert.Equal(ConvertFromSingle(0), MinMagnitude([ConvertFromSingle(-1), ConvertFromSingle(-0f), ConvertFromSingle(1)]));
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/96443", TestRuntimes.Mono)]
[Fact]
public void MinMagnitude_TwoTensors()
{
Expand All @@ -1878,7 +1872,6 @@ public void MinMagnitude_TwoTensors()
});
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/96443", TestRuntimes.Mono)]
[Fact]
public void MinMagnitude_TwoTensors_InPlace()
{
Expand Down Expand Up @@ -1907,7 +1900,6 @@ public void MinMagnitude_TwoTensors_InPlace()
});
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/96443", TestRuntimes.Mono)]
[Fact]
public void MinMagnitude_TwoTensors_SpecialValues()
{
Expand Down
7 changes: 7 additions & 0 deletions src/libraries/System.Runtime.Intrinsics/tests/Vectors/Vector128Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4544,6 +4544,13 @@ public void Vector128SByteAbs_MinValue()
}
}

[Fact]
public void Vector128NuintGreaterThan_MaxValue()
{
Vector128<nuint> vector = Vector128.Create(nuint.MaxValue);
Assert.True(Vector128.EqualsAll(Vector128.GreaterThan(vector, Vector128<nuint>.Zero), vector));
}

[Fact]
public void IsSupportedByte() => TestIsSupported<byte>();

Expand Down
4 changes: 2 additions & 2 deletions src/mono/mono/mini/mini-amd64.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3415,9 +3415,9 @@ simd_type_to_shl_op (int t)
case MONO_TYPE_I:
case MONO_TYPE_U:
#if TARGET_SIZEOF_VOID_P == 8
return OP_PSHLD;
#else
return OP_PSHLQ;
#else
return OP_PSHLD;
#endif
default:
g_assert_not_reached ();
Expand Down