Clean up and consolidate HostModel tests. #97244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elinor-fung
added
test-enhancement
|
Tagging subscribers to this area: @vitek-karas, @agocke Issue Details
|
ghost
assigned
This was referenced Jan 20, 2024
Closed
vitek-karas
approved these changes
Jan 21, 2024
src/installer/tests/Microsoft.NET.HostModel.Tests/Microsoft.NET.HostModel.Tests.csproj
Outdated
Show resolved
Hide resolved
…T.HostModel.Tests.csproj
2 tasks
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
- Merge HostModel AppHost/Bundle/ComHost tests into one `Microsoft.NET.HostModel.Tests` project - Move symbolic link tests into `HostActivation.Tests` - they are not testing HostModel - Rename `AppHostUpdateTests` to `CreateAppHost` - that is the API they are testing - Switch `AppWithUnknownLanguageResource` to pre-built asset - Move to `CreateAppHost` test class
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft.NET.HostModel.TestsprojectHostActivation.Tests- they are not testing HostModelAppHostUpdateTeststoCreateAppHost- that is the API they are testingAppWithUnknownLanguageResourceto pre-built assetCreateAppHosttest class