Forward the pgoinstrument argument to the inner build for VMR/Source-build builds #98446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsContributes to dotnet/source-build#3889, dotnet/source-build#3893, dotnet/source-build#3896, dotnet/source-build#3866, dotnet/source-build#3856
|
jkoritzinsky
force-pushed
the
vmr-pgoinstrument
branch
from
8901211 to
00bb6ab
Compare
This was referenced Feb 15, 2024
…build builds Build all assets when we're building PGO-instrumented assets in a vertical build/source-build scenario (where we won't have assets from a non-PGO-instrumented job available)
jkoritzinsky
force-pushed
the
vmr-pgoinstrument
branch
from
00bb6ab to
6d82f35
Compare
mmitche
reviewed
Feb 16, 2024
mmitche
approved these changes
Feb 16, 2024
Co-authored-by: Matt Mitchell <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/source-build#3889, dotnet/source-build#3893, dotnet/source-build#3896, dotnet/source-build#3866, dotnet/source-build#3856
This PR also enables building all assets when doing a vertical build with PgoInstrument=true, so we can build everything without needing a non-PGO-instrumented build as well.