Skip to content

Fix incorrect exception argument in DbConnectionOptions #98826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix incorrect exception argument in DbConnectionOptions #98826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Data.Common/src/System/Data/Common/DbConnectionOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ internal static void ValidateKeyValuePair(string keyword, string value)
}
if ((null != value) && value.Contains('\0'))
{
throw ADP.InvalidValue(keyword);
throw ADP.InvalidValue(value);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, why does this need to change to value? The argument here is the parameter name, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am actually considering that it should be nameof(value). It's expecting the parameter name, returning an ArgumentException.

https://source.dot.net/#System.Data.Common/System/Data/Common/AdapterUtil.Common.cs,723f78a5c15d5418,references

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you mean that the value of keyword should be the parameter name since it's triggered when setting the indexer and it is meant to show this as the source

https://source.dot.net/#System.Data.Common/System/Data/Common/DbConnectionStringBuilder.cs,98

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you mean that the value of keyword should be the parameter name since it's triggered when setting the indexer and it is meant to show this as the source

https://source.dot.net/#System.Data.Common/System/Data/Common/DbConnectionStringBuilder.cs,98

Right, I suspect that was the original intent.

}
}
}
Expand Down