Skip to content

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Feb 25, 2024

it's no longer needed.

Diffs are empty.

@ghost ghost assigned EgorBo Feb 25, 2024
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 25, 2024
@ghost
Copy link

ghost commented Feb 25, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: EgorBo
Assignees: EgorBo
Labels:

area-CodeGen-coreclr

Milestone: -

@EgorBo EgorBo marked this pull request as ready for review February 25, 2024 21:25
@EgorBo
Copy link
Member Author

EgorBo commented Feb 26, 2024

@dotnet/jit-contrib PTAL, empty diff clean up (became possible after #98733 and #98623)

@SingleAccretion
Copy link
Contributor

The following TODOs can now be fixed:

// TODO-1stClassStructs: delete layout-less "IND(struct)" nodes and the "loadSize == 0" condition.
if (loadSize == 0)
{
tree->gtVNPair.SetBoth(vnStore->VNForExpr(compCurBB, loadType));
}

// TODO-1stClassStructs: delete once IND<struct> nodes are no more.
assert(!op1->TypeIs(TYP_STRUCT) && !op2->TypeIs(TYP_STRUCT));

// TODO-1stClassStructs: delete once IND<struct> nodes are no more.
if (node->TypeGet() == TYP_STRUCT)
{
doAddrMode = false;
}

@EgorBo
Copy link
Member Author

EgorBo commented Feb 26, 2024

The following TODOs can now be fixed:

Thanks, done!

@EgorBo EgorBo merged commit 51b51bf into dotnet:main Feb 27, 2024
@EgorBo EgorBo deleted the remove-dynblock-2 branch February 27, 2024 10:31
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants