Skip to content

[browser][wbt] Fix not failing download for DownloadProgressFinishes test when randomly picked index is zero #98985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2024
Merged

[browser][wbt] Fix not failing download for DownloadProgressFinishes test when randomly picked index is zero #98985

merged 2 commits into from
Feb 28, 2024

Conversation

maraf
Copy link
Member

@maraf maraf commented Feb 27, 2024

Fixes #98486

@maraf maraf added arch-wasm WebAssembly architecture test-enhancement Improvements of test source code area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Feb 27, 2024
@maraf maraf added this to the 9.0.0 milestone Feb 27, 2024
@maraf maraf self-assigned this Feb 27, 2024
@maraf maraf requested a review from ilonatommy as a code owner February 27, 2024 13:25
@ghost
Copy link

ghost commented Feb 27, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #98486

Author: maraf
Assignees: maraf
Labels:

arch-wasm, test-enhancement, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone: 9.0.0

ilonatommy
ilonatommy approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@ilonatommy ilonatommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit change only

This was referenced Feb 27, 2024
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Feb 28, 2024
Closed
@maraf maraf changed the title [browser][wbt] Fix not failing DownloadProgressFinishes test when randomly picked index is zero [browser][wbt] Fix not failing download for DownloadProgressFinishes test when randomly picked index is zero Feb 28, 2024
@maraf maraf merged commit a2761cc into dotnet:main Feb 28, 2024
@maraf maraf deleted the BrowserDownloadProgressFinishes branch February 28, 2024 09:04
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilonatommy ilonatommy ilonatommy approved these changes

Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm test-enhancement Improvements of test source code
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

[browser][WBT] DownloadResourceProgressTests.DownloadProgressFinishes
2 participants
@maraf @ilonatommy