Introduce HandleKindDataIsInvariant helper
#99744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small helper to identify if a handle kind is invariant.
ghost
added
the
area-CodeGen-coreclr
|
Extracted from #94250 |
BruceForstall
added a commit
to BruceForstall/runtime
that referenced
this pull request
Mar 14, 2024
This includes various fixes that are being separately PR'ed: 1. dotnet#99744: Introduce HandleKindDataIsInvariant helper 2. dotnet#99743: Add basic support for TYP_MASK constants 3. dotnet#99742: Fix problem with scaling general loop blocks; add dumpers 4. dotnet#99740: Add edge likelihood dumping; fix one edge likelihood update case Also: 1. Add support for running JitOptRepeat under JitStress. This is still over-written by JitOptRepeat being forced on at 4 iterations.
jakobbotsch
reviewed
Mar 14, 2024
src/coreclr/jit/gentree.cpp
Outdated
Comment on lines
10813
to
10815
| return !((handleKind == GTF_ICON_STATIC_HDL) || // Pointer to a mutable class Static variable | ||
| (handleKind == GTF_ICON_BBC_PTR) || // Pointer to a mutable basic block count value | ||
| (handleKind == GTF_ICON_GLOBAL_PTR)); // Pointer to mutable data from the VM state |
jakobbotsch
approved these changes
Mar 14, 2024
filipnavara
reviewed
Mar 14, 2024
Co-authored-by: Filip Navara <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small helper to identify if a handle kind is invariant.