Skip to content

fix formatting #15126 #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Conversation

ShoSashko
Copy link
Contributor

@ShoSashko ShoSashko commented Oct 12, 2019

@ShoSashko ShoSashko requested a review from BillWagner as a code owner October 12, 2019 12:33
@dnfclas
Copy link

dnfclas commented Oct 12, 2019

CLA assistant check
All CLA requirements met.

@Potapy4
Copy link
Contributor

Potapy4 commented Oct 12, 2019

Fixes dotnet/docs#15126

@Rick-Anderson
Copy link
Contributor

@mairaw is there anyway to see what the build looks like?

@ShoSashko
Copy link
Contributor Author

@Rick-Anderson is there a way to build it locally?

@mairaw
Copy link
Contributor

mairaw commented Oct 15, 2019

Not that I'm aware @Rick-Anderson. I think there is a way to build locally but I never got it to work.

Let's merge and check?

@Rick-Anderson
Copy link
Contributor

@mairaw asked:

Let's merge and check?

Yes!

@mairaw mairaw merged commit 6ba740f into dotnet:master Oct 17, 2019
@mairaw
Copy link
Contributor

mairaw commented Oct 17, 2019

It's rebuilding on master branch now. We can check how it looks on https://review.docs.microsoft.com/en-us/dotnet/standard/io/pipelines?branch=master soon.

@ozholob
Copy link

ozholob commented Oct 21, 2019

@mairaw Let me know if that requires some additional updates because I haven't access to the
https://review.docs.microsoft.com/en-us/dotnet/standard/io/pipelines?branch=master :)

@Rick-Anderson
Copy link
Contributor

This is what it looks like in tablet mode (widest browser with no left or right TOC)

image

image

image

image

image

image

image

image

@ShoSashko ShoSashko deleted the formatting_documentation branch October 22, 2019 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format pipeline code
6 participants