add ref local reassignment #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
changed the title
pkulikov
reviewed
Apr 4, 2018
| { | ||
| retval += $"{numbers[ctr]} "; | ||
| } | ||
| return retval.Trim(); |
There was a problem hiding this comment.
I see that is pre-existing code, but to make snippet shorter what about such ToString() implementation:
public override string ToString() => string.Join(" ", numbers);Same remark also for the NumberStoreUpdated.cs file
And build project around the sample.
The newer version shows a sample where the ref local reassignment feature creates more efficient code.
BillWagner
force-pushed
the
csharp73-ref-local-reassignment
branch
from
7cd9599 to
ed9ea0f
Compare
rpetrusha
approved these changes
Apr 10, 2018
There was a problem hiding this comment.
LGTM, @BillWagner, except I'm wondering what the // #error version comment in Program.cs means. You can merge when you're ready.
BillWagner
added
the
🚧 Hold for related PR
|
This PR must not be merged until dotnet/docs#4875 |
|
Thanks @rpetrusha That comment was a test and a reminder to add a note on another issue. |
karelz
pushed a commit
to karelz/samples
that referenced
this pull request
Aug 31, 2018
* add ref local reassignment And build project around the sample. * update code sample The newer version shows a sample where the ref local reassignment feature creates more efficient code. * feedback Use expression bodied members for ToString. * remove the error pragma comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And build project around the sample.
Sample updates for dotnet/docs#3961