Binding redirects are not generated automatically

[davkean]

From @davidmatson on March 21, 2017 3:31

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <OutputType>WinExe</OutputType>
    <TargetFramework>net452</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Newtonsoft.Json" Version="9.0.1" />
    <PackageReference Include="WindowsAzure.Storage" Version="7.2.1" />
  </ItemGroup>
</Project>

Expected:
Binding redirects are generated automatically.

Actual:

1>Consider app.config remapping of assembly "Newtonsoft.Json, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed" from Version "6.0.0.0" [] to Version "9.0.0.0" [C:\Users\me\.nuget\packages\newtonsoft.json\9.0.1\lib\net45\Newtonsoft.Json.dll] to solve conflict and get rid of warning.
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\Bin\Microsoft.Common.CurrentVersion.targets(1964,5): warning MSB3276: Found conflicts between different versions of the same dependent assembly. Please set the "AutoGenerateBindingRedirects" property to true in the project file. For more information, see http://go.microsoft.com/fwlink/?LinkId=294190.

Somewhat ironically, the link mentioned in the error output:
http://go.microsoft.com/fwlink/?LinkId=294190

Says that binding redirects are generated automatically if the target framework is .NET 4.5.1 or higher. This project targets .NET 4.5.2, but the binding redirects are still not generated automatically.

Current workaround is to add the property explicitly:

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <OutputType>WinExe</OutputType>
    <TargetFramework>net452</TargetFramework>
    <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Newtonsoft.Json" Version="9.0.1" />
    <PackageReference Include="WindowsAzure.Storage" Version="7.2.1" />
  </ItemGroup>
</Project>

Copied from original issue: dotnet/project-system#1809

[dsplaisted]

It looks like the issue here is that this condition needs to check for an output type of WinExe in addition to Exe:

  <PropertyGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework' and '$(OutputType)' == 'Exe'">
    <AutoGenerateBindingRedirects Condition="'$(AutoGenerateBindingRedirects)' == ''">true</AutoGenerateBindingRedirects>
  </PropertyGroup>

[davkean]

Do you even need that check? I thought we already did the right thing here in the automatic binding redirect target.

[nguerrera]

Fixed by #1178

[JoseFMP]

Has this shipped? Experiencing the same problem over here.

[davkean]

@jose-cf Please open a new bug on any issue that you are running into.

[JoseFMP]

The issue is this very same one. Should I duplicate it?

[davkean]

Yes. We will mark it as a duplicate if its the same issue.

[JoseFMP]

Ok, I created #1351. You were right, the issue is indeed different.