Check the targetext to determine if a framework project can be run on F5 #1176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should be able to run both Console Application and Windows Application on F5 for Framework Projects
|
Opened #1175 to target post preview 1 |
|
See #1175 (comment) and #1174 (comment) I'd much prefer that we fix this throughout. |
nguerrera
reviewed
May 4, 2017
| @@ -269,7 +269,7 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| </PropertyGroup> | |||
| </When> | |||
|
|
|||
| <When Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework' and '$(OutputType)' == 'Exe'"> | |||
| <When Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework' and '$(TargetExt)' == '.exe'"> | |||
There was a problem hiding this comment.
Another note: WinExe support on core may be coming soon: dotnet/core-setup#196
|
Closing in favor of #1178 |
mmitche
pushed a commit
to mmitche/sdk
that referenced
this pull request
Jun 5, 2020
…223.1 (dotnet#1176) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19623.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be able to run both Console Application and Windows Application on F5 for Framework Projects
This is to address the issue project-system/2033
Tagging @dotnet/project-system @srivatsn @davkean for review