Don't cross compile GetAssemblyVersion

[ericstj]

Previously we cross-compiled the GetAssemblyVersion method to avoid
a dependency on MetadataReader on desktop. This had the downside of
causing first chance exceptions when run on desktop.

This has the tradeoff of introducing a Reflection.Metadata dependency on
desktop which will increase the layout by ~700KB (for SRM and SCI).

What are folks thoughts on that tradeoff? /cc @dsplaisted @KirillOsenkov @eerhardt

[KirillOsenkov]

I have a feeling that SRM will be used more and more in the future so might as well start taking advantage of it earlier.

[eerhardt]

What about doing this the opposite way? If we target netstandard2.0 in our build task, we can use the desktop code on both desktop and .net core.

Nevermind, I see we are trying to fix the first chance exception problem on desktop.

[ericstj]

Tests are failing because S.C.I is missing: error MSB4018: System.IO.FileNotFoundException: Could not load file or assembly 'System.Collections.Immutable, Version=1.2.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified. I must have missed one of the places where I need to provide this... Looking

[ericstj]

This is failing because of lack of bindingRedirects in SDK:

LOG: Attempting download of new URL file:///F:/dotnet/sdk/bin/Debug/Sdks/Microsoft.NET.Sdk/tools/net46/System.Collections.Immutable.DLL.
WRN: Comparing the assembly name resulted in the mismatch: Build Number

[ericstj]

FWIW this is exactly why I was trying to avoid dependencies in the desktop build.

[nguerrera]

dotnet/msbuild#1309

[nguerrera]

I'm inclined to close this until msbuild provides a simple mechanism for binding redirects in tasks. I don't think 800kb + a custom assembly resolve implementation is worth it in the meantime.

[ericstj]

Agreed. I suppose another alternative would be to implement our own early check for managed assembly using the code sample @KirillOsenkov shared: https://github.com/KirillOsenkov/MetadataTools/blob/master/PEFile/IsManagedAssembly.cs

But then I'd question if a second file open/read is worth getting rid of the first chance exception.