Add netstandard support facades when ns1.5+ libraries are referenced #1387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we only added the netstandard2.0 facades when a netstandard2.0 library was referenced. This will also apply them if a netstandard1.5 or greater library is referenced. This addresses the case where packages (like System.Runtime) are broken after NuGet remapped net461 from netstandard1.4 to netstandard2.0.
livarcocc
approved these changes
Jul 5, 2017
|
Customer scenario Previously we only added the netstandard2.0 facades when a netstandard2.0 library This will also apply them if a netstandard1.5 or greater library is referenced. This addresses the case where packages (like System.Runtime) are broken after NuGet Bugs this fixes: Fixes #1386 Workarounds, if any None. Risk Low Performance impact N/A Is this a regression from a previous update? Yes. Root cause analysis: Change in Nuget that we are re-acting to. How was the bug found? Reported by team member. @dotnet/dotnet-cli for review @MattGertz for approval |
dsplaisted
approved these changes
Jul 6, 2017
GangWang01
pushed a commit
to GangWang01/sdk
that referenced
this pull request
Jun 7, 2022
…ol_in_cache Script running post action bool in cache
GangWang01
pushed a commit
to GangWang01/sdk
that referenced
this pull request
Jul 11, 2022
…ol_in_cache Script running post action bool in cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only added the netstandard2.0 facades when a netstandard2.0 library
was referenced.
This will also apply them if a netstandard1.5 or greater library is referenced.
This addresses the case where packages (like System.Runtime) are broken after NuGet
remapped net461 from netstandard1.4 to netstandard2.0.
Fixes #1386
/cc @livarcocc @dsplaisted