Skip to content

Conversation

dsplaisted
Copy link
Member

#14393 broke projects that set UseWPF or UseWindowsForms in Directory.Build.targets.

This PR fixes that.

However, we probably want WPF and Windows Forms to be in their own workload eventually, at which point this would break again. So we're not sure we want to take this PR yet.

@ghost
Copy link

ghost commented Jan 22, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ryalanms
Copy link
Member

@dsplaisted: Does this also need to go into master?

@dsplaisted
Copy link
Member Author

@dsplaisted: Does this also need to go into master?

If we take this change, it will eventually go to master too.

@wli3
Copy link

wli3 commented Jan 26, 2021

@dsplaisted I don't think we get a clear decision during the meeting. Do we want to merge this? Or completely revert the change for Xamarin props import

@dsplaisted
Copy link
Member Author

@dsplaisted I don't think we get a clear decision during the meeting. Do we want to merge this? Or completely revert the change for Xamarin props import

Yes, we want to merge this. It avoids the breaking change for now while we will continue to work on figuring out the right way to handle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants