Skip to content

Suppress generating source checksum attribute #16468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

pranavkm
Copy link
Contributor

Follow up to dotnet/aspnetcore#31089.

Consume the new attribute to turn off generating source checksum attributes by default.

Follow up to dotnet/aspnetcore#31089.

Consume the new attribute to turn off generating source
checksum attributes by default.
@ghost
Copy link

ghost commented Mar 22, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@pranavkm pranavkm requested a review from a team March 22, 2021 14:18
@mkArtakMSFT mkArtakMSFT added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch label Mar 22, 2021
/// For instance <c>dotnet msbuild /p:_RazorSourceGeneratorLog=true</c>
/// </para>
public bool EnableLogging { get; private set; }
public bool GenerateMetadataSourceChecksumAttributes { get; private set; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this also a replacement for logging ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unused

Copy link
Contributor

@TanayParikh TanayParikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pranavkm pranavkm merged commit 81e9744 into main Mar 22, 2021
@pranavkm pranavkm deleted the prkrishn/suppress-source-checksum branch March 22, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants