[release/6.0-preview5] Add support for Pgo Mibc files to be used by the SDK for Preview5 #17930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- A new ItemList (PublishReadyToRunPgoFiles) can be used to specify a custom list of Mibc files - Any Mibc files defined in associated RuntimePacks via a RuntimeAsset with AssetType PgoData will also be included This behavior can be disabled by setting PublishReadyToRunUseRuntimePackOptimizationData to false
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Adding @marcpopMSFT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to upgrade the RuntimeList.xml file schema for building the RuntimeList.xml in the runtime repo, we must update the SDK to be able to consume them. (The SDK update must happen before the runtime repo can generate the new data as the runtime repo has a testbed which depends on the LKG of the SDK to be able to process existing files.)
Pgo Mibc file consumption from within a RuntimeList.xml file is necessary to enable end customers to take advantage our our static pgo system when producing trimmed, R2R'd published self-contained applications, or self-contained R2R composite images.
Customer Impact
By adding this work to Preview5, we will be able to expose static pgo data to consumers in long-term serviceable manner in Preview7. In addition, this will enable customers in Preview5 to use their own locally generated static pgo data. However, as we do not intend to advertise that feature in Preview5, it is not expected that customers will see any impact.
Testing
Local ad-hoc testing of runtime repo.
Risk
Minimal. No new logic will activate until the runtime produces a RuntimeList.xml with the new content.