Skip to content

Turn off publishing for Debug configurations on PR #19701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Turn off publishing for Debug configurations on PR #19701

merged 1 commit into from
Aug 13, 2021

Conversation

joeloff
Copy link
Member

@joeloff joeloff commented Aug 12, 2021

Turning off publishing for Debug configurations on PR builds to avoid publishing multiple artifacts to the same blob

@ghost ghost added the Area-WebSDK label Aug 12, 2021
@joeloff
Copy link
Member Author

joeloff commented Aug 12, 2021

Fixes #19679

@joeloff joeloff requested a review from wli3 August 12, 2021 20:24
@joeloff
Copy link
Member Author

joeloff commented Aug 12, 2021

FYI @danmoseley @ViktorHofer

@ViktorHofer ViktorHofer requested a review from mmitche August 13, 2021 06:18
@joeloff joeloff merged commit 3b00976 into main Aug 13, 2021
@joeloff joeloff deleted the 19679 branch August 13, 2021 17:07
@lewing
Copy link
Member

lewing commented Aug 17, 2021

@mmitche
Copy link
Member

mmitche commented Aug 17, 2021

@joeloff
Copy link
Member Author

joeloff commented Aug 17, 2021

Yeah, I noticed something similar where we have two release legs doing the same thing. I haven't quite figured out what I'm going to do there.

@mmitche would it be silly to condition these targets against the build agent job name to turn it of for one of these legs? I don't see another way of doing it.

@mmitche
Copy link
Member

mmitche commented Aug 17, 2021

Yeah, I noticed something similar where we have two release legs doing the same thing. I haven't quite figured out what I'm going to do there.

@mmitche would it be silly to condition these targets against the build agent job name to turn it of for one of these legs? I don't see another way of doing it.

I don't think you need to. just need to set _PublishArgs to '' https://github.com/dotnet/sdk/blob/main/.vsts-ci.yml#L92 and https://github.com/dotnet/sdk/blob/main/.vsts-ci.yml#L108

There are 3 windows nt configs.

@joeloff
Copy link
Member Author

joeloff commented Aug 17, 2021

yeah, but I think we need some of the full framework artifacts, almost everything except this one zip

@mmitche
Copy link
Member

mmitche commented Aug 17, 2021

yeah, but I think we need some of the full framework artifacts, almost everything except this one zip

The FullFramework and TestAsTools configs are just for testing. They don't even run in official builds: https://dev.azure.com/dnceng/internal/_build/results?buildId=1299530&view=logs&s=6884a131-87da-5381-61f3-d7acc3b91d76&j=fa59fe4e-195c-56fa-189b-58fd241f10dd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants