Update a bunch of test projects to the current target framework #20148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made pass over A-M letters in project. Had to fix a test to workaround bug #19487
ghost
added
the
marcpopMSFT
changed the title
marcpopMSFT
force-pushed
the
marcpopMSFT-testimprovements
branch
2 times, most recently
from
add6dae to
389b657
Compare
…xtra ref files, missing dev.json, and analyzer changes. Lots of tests had hardcoded TFMs in the test itself as well.
marcpopMSFT
force-pushed
the
marcpopMSFT-testimprovements
branch
from
389b657 to
1b6d4a0
Compare
|
@marcpopMSFT Didn't I already review this? Was it a different PR, or did I just look at this but never actually review it? |
|
@dsplaisted The first PR I did that you're thinking of included all of the HelloWorld* projects to prove out the concept. This PR does all of the test projects that start with letters A through M. Jason was going to pick up and handle the rest. I split them up into batches figuring it'd be easier to review, easier to get passing, and easier to split up with Jason. |
dsplaisted
approved these changes
Sep 16, 2021
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildAComServerLibrary.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildAnAppWithLibrariesAndRid.cs
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Pack.Tests/GivenThatWeWantToPackACrossTargetedLibrary.cs
Outdated
Show resolved
Hide resolved
…app rather than setting it in specific tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3678
Added TargetFrameworks support for current TF.
Made pass over A-M letters in project.
Had to fix a test to workaround bug #19487