Skip to content

[WIP] Add warning for ref to netstandard >= 1.5 from netfx without built-in support #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[WIP] Add warning for ref to netstandard >= 1.5 from netfx without built-in support #2316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52046a3
Add warning for ref to netstandard >= 1.5 from netfx without built-in…
nguerrera Jun 7, 2018
f4f94f1
Update XLF
nguerrera Jun 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Tasks/Common/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,4 +381,8 @@ The following are names of parameters or literal values and should not be transl
<value>NETSDK1065: Cannot find app host for {0}. {0} could be an invalid runtime identifier (RID). For more information about RID, see https://aka.ms/rid-catalog.</value>
<comment>{StrBegin="NETSDK1065: "}</comment>
</data>
</root>
<data name="NETFrameworkToNonBuiltInNETStandard" xml:space="preserve">
<value>NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest:

This project uses a library that targets .NET Standard 1.5 or higher and targets a version of .NET Framework that does not have built-in support for that version of .NET Standard. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.

I'd also suggest creating an aka.ms link instead of a fwlink, that way we can choose a name that's easier to type in, for example http://aka.ms/net-standard-known-issues.

@mairaw Can you review this for style?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your suggestion LGTM @dsplaisted! Only nit per Microsoft style guide is the use of contractions
does not -> doesn't

<comment>{StrBegin="NETSDK1066: "}</comment>
</data>
</root>
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="needs-review-translation">Je potřeba zadat alespoň jednu možnou cílovou platformu</target>
<note>{StrBegin="NETSDK1001: "}</note>
</trans-unit>
<trans-unit id="NETFrameworkToNonBuiltInNETStandard">
<source>NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</source>
<target state="new">NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</target>
<note>{StrBegin="NETSDK1066: "}</note>
</trans-unit>
<trans-unit id="NoCompatibleTargetFramework">
<source>NETSDK1002: Project '{0}' targets '{2}'. It cannot be referenced by a project that targets '{1}'.</source>
<target state="needs-review-translation">Cílem projektu {0} je {2}. Nemůže na něj odkazovat projekt, jehož cílem je {1}.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="needs-review-translation">Geben Sie mindestens ein mögliches Zielframework an.</target>
<note>{StrBegin="NETSDK1001: "}</note>
</trans-unit>
<trans-unit id="NETFrameworkToNonBuiltInNETStandard">
<source>NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</source>
<target state="new">NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</target>
<note>{StrBegin="NETSDK1066: "}</note>
</trans-unit>
<trans-unit id="NoCompatibleTargetFramework">
<source>NETSDK1002: Project '{0}' targets '{2}'. It cannot be referenced by a project that targets '{1}'.</source>
<target state="needs-review-translation">Das Projekt "{0}" hat das Ziel "{2}". Ein Verweis von einem Projekt mit dem Ziel "{1}" ist nicht möglich.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="needs-review-translation">Debe especificarse al menos una plataforma de destino posible.</target>
<note>{StrBegin="NETSDK1001: "}</note>
</trans-unit>
<trans-unit id="NETFrameworkToNonBuiltInNETStandard">
<source>NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</source>
<target state="new">NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</target>
<note>{StrBegin="NETSDK1066: "}</note>
</trans-unit>
<trans-unit id="NoCompatibleTargetFramework">
<source>NETSDK1002: Project '{0}' targets '{2}'. It cannot be referenced by a project that targets '{1}'.</source>
<target state="needs-review-translation">El proyecto "{0}" tiene como destino "{2}". No se puede hacer referencia a él mediante un proyecto que tenga como destino "{1}".</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="needs-review-translation">Au moins un framework cible doit être spécifié.</target>
<note>{StrBegin="NETSDK1001: "}</note>
</trans-unit>
<trans-unit id="NETFrameworkToNonBuiltInNETStandard">
<source>NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</source>
<target state="new">NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</target>
<note>{StrBegin="NETSDK1066: "}</note>
</trans-unit>
<trans-unit id="NoCompatibleTargetFramework">
<source>NETSDK1002: Project '{0}' targets '{2}'. It cannot be referenced by a project that targets '{1}'.</source>
<target state="needs-review-translation">Le projet '{0}' cible '{2}'. Il ne peut pas être référencé par un projet qui cible '{1}'.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="needs-review-translation">È necessario specificare almeno un framework di destinazione possibile.</target>
<note>{StrBegin="NETSDK1001: "}</note>
</trans-unit>
<trans-unit id="NETFrameworkToNonBuiltInNETStandard">
<source>NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</source>
<target state="new">NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</target>
<note>{StrBegin="NETSDK1066: "}</note>
</trans-unit>
<trans-unit id="NoCompatibleTargetFramework">
<source>NETSDK1002: Project '{0}' targets '{2}'. It cannot be referenced by a project that targets '{1}'.</source>
<target state="needs-review-translation">Il progetto '{0}' è destinato a '{2}'. Non può essere usato come riferimento in un progetto destinato a '{1}'.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="needs-review-translation">可能性のあるターゲット フレームワークを少なくとも 1 つ指定する必要があります。</target>
<note>{StrBegin="NETSDK1001: "}</note>
</trans-unit>
<trans-unit id="NETFrameworkToNonBuiltInNETStandard">
<source>NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</source>
<target state="new">NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</target>
<note>{StrBegin="NETSDK1066: "}</note>
</trans-unit>
<trans-unit id="NoCompatibleTargetFramework">
<source>NETSDK1002: Project '{0}' targets '{2}'. It cannot be referenced by a project that targets '{1}'.</source>
<target state="needs-review-translation">プロジェクト '{0}' は、'{2}' を対象としています。'{1}' を対象とするプロジェクトは、これを参照できません。</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="needs-review-translation">가능한 대상 프레임워크를 하나 이상 지정해야 합니다.</target>
<note>{StrBegin="NETSDK1001: "}</note>
</trans-unit>
<trans-unit id="NETFrameworkToNonBuiltInNETStandard">
<source>NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</source>
<target state="new">NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</target>
<note>{StrBegin="NETSDK1066: "}</note>
</trans-unit>
<trans-unit id="NoCompatibleTargetFramework">
<source>NETSDK1002: Project '{0}' targets '{2}'. It cannot be referenced by a project that targets '{1}'.</source>
<target state="needs-review-translation">'{0}' 프로젝트가 '{2}'을(를) 대상으로 합니다. '{1}'을(를) 대상으로 하는 프로젝트에서 참조할 수 없습니다.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="needs-review-translation">Należy określić co najmniej jedną możliwą platformę docelową.</target>
<note>{StrBegin="NETSDK1001: "}</note>
</trans-unit>
<trans-unit id="NETFrameworkToNonBuiltInNETStandard">
<source>NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</source>
<target state="new">NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</target>
<note>{StrBegin="NETSDK1066: "}</note>
</trans-unit>
<trans-unit id="NoCompatibleTargetFramework">
<source>NETSDK1002: Project '{0}' targets '{2}'. It cannot be referenced by a project that targets '{1}'.</source>
<target state="needs-review-translation">Projekt „{0}” ma platformę docelową „{2}”. Nie może on być przywoływany przez projekt z platformą docelową „{1}”.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="needs-review-translation">É necessário especificar pelo menos uma estrutura de destino possível.</target>
<note>{StrBegin="NETSDK1001: "}</note>
</trans-unit>
<trans-unit id="NETFrameworkToNonBuiltInNETStandard">
<source>NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</source>
<target state="new">NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</target>
<note>{StrBegin="NETSDK1066: "}</note>
</trans-unit>
<trans-unit id="NoCompatibleTargetFramework">
<source>NETSDK1002: Project '{0}' targets '{2}'. It cannot be referenced by a project that targets '{1}'.</source>
<target state="needs-review-translation">O projeto '{0}' tem como destino '{2}'. Ele não pode ser referenciado por um projeto que tenha '{1}' como destino.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.ru.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="needs-review-translation">Необходимо указать хотя бы одну целевую платформу.</target>
<note>{StrBegin="NETSDK1001: "}</note>
</trans-unit>
<trans-unit id="NETFrameworkToNonBuiltInNETStandard">
<source>NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</source>
<target state="new">NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</target>
<note>{StrBegin="NETSDK1066: "}</note>
</trans-unit>
<trans-unit id="NoCompatibleTargetFramework">
<source>NETSDK1002: Project '{0}' targets '{2}'. It cannot be referenced by a project that targets '{1}'.</source>
<target state="needs-review-translation">Проект "{0}" предназначен для платформы "{2}". На него не может ссылаться проект, предназначенный для платформы "{1}".</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.tr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="needs-review-translation">En az bir olası hedef çerçeve belirtilmelidir.</target>
<note>{StrBegin="NETSDK1001: "}</note>
</trans-unit>
<trans-unit id="NETFrameworkToNonBuiltInNETStandard">
<source>NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</source>
<target state="new">NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</target>
<note>{StrBegin="NETSDK1066: "}</note>
</trans-unit>
<trans-unit id="NoCompatibleTargetFramework">
<source>NETSDK1002: Project '{0}' targets '{2}'. It cannot be referenced by a project that targets '{1}'.</source>
<target state="needs-review-translation">'{0}' projesi, '{2}' çerçevesini hedefliyor. Bu projeye '{1}' çerçevesini hedefleyen bir proje tarafından başvurulamaz.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.zh-Hans.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="needs-review-translation">必须指定至少一个可能的目标框架。</target>
<note>{StrBegin="NETSDK1001: "}</note>
</trans-unit>
<trans-unit id="NETFrameworkToNonBuiltInNETStandard">
<source>NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</source>
<target state="new">NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</target>
<note>{StrBegin="NETSDK1066: "}</note>
</trans-unit>
<trans-unit id="NoCompatibleTargetFramework">
<source>NETSDK1002: Project '{0}' targets '{2}'. It cannot be referenced by a project that targets '{1}'.</source>
<target state="needs-review-translation">项目“{0}”以“{2}”为目标。它不可由面向“{1}”的项目引用。</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.zh-Hant.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="needs-review-translation">必須指定至少一個可能的目標 Framework。</target>
<note>{StrBegin="NETSDK1001: "}</note>
</trans-unit>
<trans-unit id="NETFrameworkToNonBuiltInNETStandard">
<source>NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</source>
<target state="new">NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</target>
<note>{StrBegin="NETSDK1066: "}</note>
</trans-unit>
<trans-unit id="NoCompatibleTargetFramework">
<source>NETSDK1002: Project '{0}' targets '{2}'. It cannot be referenced by a project that targets '{1}'.</source>
<target state="needs-review-translation">專案 '{0}' 以 '{2}' 為目標。以 '{1}' 為目標的專案無法參考該專案。</target>
Expand Down
4 changes: 4 additions & 0 deletions ...rosoft/Microsoft.NET.Build.Extensions/Microsoft.NET.Build.Extensions.NETFramework.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,10 @@ Copyright (c) .NET Foundation. All rights reserved.
Exclude="@(_NETStandardLibraryNETFrameworkLib->'$(MSBuildThisFileDirectory)net461\lib\%(FileName).dll')" />
</ItemGroup>

<NETBuildExtensionsWarning Condition="'@(_NETStandardLibraryNETFrameworkLib)' != ''"
ResourceName="NETFrameworkToNonBuiltInNETStandard"
/>

<ItemGroup Condition="'@(_NETStandardLibraryNETFrameworkLib)' != ''">
<!-- Remove simple name references if we're directly providing a reference assembly to the compiler. For example,
consider a project with a Reference Include="System.Net.Http" or "System.IO.Compression", which are both in
Expand Down