Skip to content

Update Blazor WASM Baselines for new files #27201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 18, 2022
Merged

Update Blazor WASM Baselines for new files #27201

merged 3 commits into from
Aug 18, 2022

Conversation

TanayParikh
Copy link
Contributor

@TanayParikh TanayParikh commented Aug 16, 2022 •
edited
Loading

Updated baselines for #27149.

@ghost ghost added the Area-Infrastructure label Aug 16, 2022
@TanayParikh
Copy link
Contributor Author

@javiercn your diffset for #26966 was a lot more concise. Did you do additional post-processing after rerunning the tests with GENERATE_SWA_BASELINES defined?

@javiercn
Copy link
Member

@TanayParikh no, I did not.

@TanayParikh
Copy link
Contributor Author

@TanayParikh no, I did not.

So is this fine to merge in that case? Surprised the diff is so large.

@lewing
Copy link
Member

lewing commented Aug 16, 2022

The identity changes look a little odd, do we know what is causing them?

@TanayParikh
Copy link
Contributor Author

do we know what is causing them?

cc @pavelsavara @radical @maraf

javiercn
javiercn approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@javiercn javiercn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, provided we want the files there

Not sure why the diffs are changing so much. @TanayParikh we need to investigate, probably debugging through a test is the easiest way

@javiercn javiercn self-requested a review August 17, 2022 10:04
@MackinnonBuck MackinnonBuck marked this pull request as ready for review August 18, 2022 18:38
@lewing lewing mentioned this pull request Aug 18, 2022
Merged
@lewing
Copy link
Member

lewing commented Aug 18, 2022

The new assemblies are showing up for a known reason, we're working on a solution to that but it shouldn't block rc1

@MackinnonBuck
Copy link
Member

MackinnonBuck commented Aug 18, 2022 •
edited
Loading

@lewing Are we clear to merge this, then? The unusual diffs have been resolved.

@lewing
Copy link
Member

lewing commented Aug 18, 2022

@MackinnonBuck the count differences are fine but I'm not sure why the paths are different in this commit I'd like someone on the aspnetcore side to take a look asap.

@kg can you take a look from the runtime side and double check that we're publishing what we think we are.

@kg
Copy link
Member

kg commented Aug 18, 2022

System.Transactions.Local makes no sense to me and I can't tell where it's coming from, but the threading ones make sense.

@lewing
Copy link
Member

lewing commented Aug 18, 2022

this should probably be merged into all the flow prs

@MackinnonBuck MackinnonBuck merged commit 4ddab3c into darc-main-b89ef279-c278-4e48-9a05-29840bb46c47 Aug 18, 2022
@MackinnonBuck MackinnonBuck deleted the taparik/updateBlazorWASMBaselines branch August 18, 2022 22:18
MackinnonBuck pushed a commit that referenced this pull request Aug 18, 2022
@TanayParikh @MackinnonBuck
Update Blazor WASM Baselines for new files (#27201)
1e0cf1e
lewing pushed a commit that referenced this pull request Aug 19, 2022
@dotnet-maestro @TanayParikh
[release/7.0.1xx-rc1] Update dependencies from dotnet/runtime (#27259)
20f30e0 
* Update dependencies from https://github.com/dotnet/runtime build 20220817.5

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0
 From Version 7.0.0-rc.1.22411.12 -> To Version 7.0.0-rc.1.22417.5

* Update dependencies from https://github.com/dotnet/runtime build 20220818.9

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0
 From Version 7.0.0-rc.1.22411.12 -> To Version 7.0.0-rc.1.22418.9

* Update Blazor WASM Baselines for new files (#27201)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Tanay Parikh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewing lewing lewing approved these changes

@radical radical Awaiting requested review from radical

@maraf maraf Awaiting requested review from maraf

@javiercn javiercn Awaiting requested review from javiercn

@captainsafia captainsafia Awaiting requested review from captainsafia

@mkArtakMSFT mkArtakMSFT Awaiting requested review from mkArtakMSFT

Assignees
No one assigned
Labels
Area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TanayParikh @javiercn @lewing @MackinnonBuck @kg