Add net8.0 ILCompiler tests #29393
Merged
Add net8.0 ILCompiler tests #29393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
LakshanF
approved these changes
Dec 6, 2022
There was a problem hiding this comment.
Thanks for doing this! Neat way of checking FX and AOT package versions!
Not related to this PR but to this test is general: Its bad that we might have to revisit to change ExplicitPackageVersion but at least its only on one place. The test scenarios are complex and are going to be challenging to follow but can't see an obvious way to make these easier to understand. Perhaps when we revisit testing OSX support, I can create a high-level test spec for this.
sbomer
force-pushed
the
nativeaotTFMTests
branch
from
719e028 to
0abf910
Compare
Now that we have ingested dotnet/runtime#79870. The test started warning that SelfContained is no longer the default due to recent changes, fixed by specifying SelfContained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the SDK can target net8.0, we can test 8.0 scenarios (and scenarios where the 8.0 SDK targets 7.0).
I also added a check that that the built-in PublishAot scenario doesn't produce packagereference warnings. This depends on dotnet/runtime#79240.