[release/7.0.2xx] [Backport] Prevent dotnet test verbosity from being ignored
#29557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rbosity-ignored Prevent `dotnet test` verbosity from being ignored
ghost
added
the
nohwnd
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from #27992 - cherry-picked commit c4b8dcc.
One of the two aliases of
Commandinstance (obtained from static classTestCommandParser, not a runtime instance of a command) needs to be passed toForwardedOptionValues.Debug visualization after the fix (note
aliasvalue):The existing test
ItUsesVerbosityPassedToDefineVerbosityOfConsoleLoggerOfTheTestswas using onlyquietmode and was testing for the wrong strings anyway (TestNamespace.VSTestTests.VSTestPassTestandTestNamespace.VSTestTests.VSTestFailTest, when only tests names are shown nowadays in case of verbosity >=normal), hence the regression.This fixed 16122.