-
Notifications
You must be signed in to change notification settings - Fork 1.1k
revert part of #29916 #29966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert part of #29916 #29966
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
@kasperk81 the .NET Framework leg is failing. |
don't think this change can cause crossgen2 crash like that. anyways, sync'd main to rerun ci. |
full framework leg passed.
in template leg isn't related (it will be fixed once #29967 is merged) |
Any idea why this is happening in main? |
/azp run dotnet-sdk-public-ci |
Azure Pipelines successfully started running 1 pipeline(s). |
Ah, we should probably add the |
@dotnet/templating-engine-maintainers https://github.com/dotnet/templating/blob/3b7bc2c69f41dd5205b850632b0f76c457254010/tools/Microsoft.TemplateEngine.Authoring.TemplateVerifier/VerificationEngine.cs#L340-L344 should probably pass the A test failed here in this PR because the template samples package was installed but then later when instantiating the templates, the update checks detected a newer templates sample package being available in the feeds:
|
@ViktorHofer now there is a new pr #29969 so it is complaining about the next version |
I am taking a look. |
to unblock linux-musl test in installer dotnet/installer#15228 (comment)