Skip to content

Add separate warnings for settings that depend on illink pack #34077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jul 31, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
68e147b
ProcessFrameworkReferences if tool packs are required
sbomer Jun 6, 2023
c9d3033
Fix test failures
sbomer Jun 7, 2023
c296167
Fix another test
sbomer Jun 7, 2023
81cc9af
Fix another test
sbomer Jun 7, 2023
8eae8ab
Merge remote-tracking branch 'origin/main' into processFrameworkRefer…
sbomer Jul 13, 2023
0739482
Fix build
sbomer Jul 13, 2023
1a136df
Limit scope of change to illink pack
sbomer Jul 13, 2023
1b5e651
Add separate warnings for settings that depend on illink pack
sbomer Jul 18, 2023
3e91ce3
Fix some tests
sbomer Jul 19, 2023
1907505
Add IsTrimmable test, fix PublishTrimmed test
sbomer Jul 19, 2023
b448b57
Clean up 'Error' from warning id
sbomer Jul 19, 2023
e7ddae6
Cleanup
sbomer Jul 19, 2023
05bf63a
Name string ids consistently
sbomer Jul 19, 2023
8b21adc
Merge branch 'processFrameworkReferencesCondition' into improveTrimmi…
sbomer Jul 19, 2023
8033c4a
Fix build
sbomer Jul 19, 2023
b6a43d9
Remove existing error path
sbomer Jul 19, 2023
2ddee37
Consolidate tests, clean up condition
sbomer Jul 20, 2023
3a09118
More cleanup
sbomer Jul 20, 2023
6d8869a
Add tests for new warnings
sbomer Jul 20, 2023
fd0f9eb
Don't consider PublishSingleFile
sbomer Jul 24, 2023
5a094ba
Merge remote-tracking branch 'origin/main' into improveTrimmingWarnings
sbomer Jul 24, 2023
721fdd2
Revert single-file test changes
sbomer Jul 24, 2023
c068281
PR feedback
sbomer Jul 27, 2023
673052a
Fix test
sbomer Jul 27, 2023
82b44df
Merge remote-tracking branch 'origin/main' into improveTrimmingWarnings
sbomer Jul 31, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/Tasks/Common/Resources/Strings.resx
Original file line number Diff line number Diff line change
Expand Up @@ -876,8 +876,10 @@ You may need to build the project on another operating system or architecture, o
<value>NETSDK1194: The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.</value>
<comment>{StrBegin="NETSDK1194: "}{Locked="--output"}</comment>
</data>
<data name="ILLinkNoValidRuntimePackageError" xml:space="preserve">
<value>NETSDK1195: Trimming, or code compatibility analysis for trimming, single-file deployment, or ahead-of-time compilation is not supported for the target framework. For more information, see https://aka.ms/netsdk1195</value>
<data name="IsTrimmableUnsupported" xml:space="preserve">
<value>NETSDK1195: IsTrimmable is not supported for the target framework. Consider multi-targeting to a supported framework to enable trimming, and set IsTrimmable only for the supported frameworks. For example:
&lt;IsTrimmable Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net6.0'))"&gt;true&lt;/IsTrimmable&gt;
For more information, see https://aka.ms/netsdk1195</value>
<comment>{StrBegin="NETSDK1195: "}</comment>
</data>
<data name="AotNotSupported" xml:space="preserve">
Expand Down Expand Up @@ -937,5 +939,15 @@ You may need to build the project on another operating system or architecture, o
<value>NETSDK1209: The current Visual Studio version does not support targeting {0} {1}. Either target {0} {2} or lower, or use Visual Studio version {3} or higher</value>
<comment>{StrBegin="NETSDK1209: "}</comment>
</data>
<!-- The latest message added is UnsupportedVisualStudioVersion. Please update this value with each PR to catch parallel PRs both adding a new message -->
<data name="IsAotCompatibleUnsupported" xml:space="preserve">
<value>NETSDK1210: IsAotCompatible is not supported for the target framework. Consider multi-targeting to a supported framework to enable ahead-of-time compilation analysis, and set IsAotCompatible only for the supported frameworks. For example:
&lt;IsAotCompatible Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net7.0'))"&gt;true&lt;/IsAotCompatible&gt;</value>
<comment>{StrBegin="NETSDK1210: "}</comment>
</data>
<data name="EnableSingleFileAnalyzerUnsupported" xml:space="preserve">
<value>NETSDK1211: EnableSingleFileAnalyzer is not supported for the target framework. Consider multi-targeting to a supported framework to enable single-file analysis, and set EnableSingleFileAnalyzer only for the supported frameworks. For example:
&lt;EnableSingleFileAnalyzer Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net6.0'))"&gt;true&lt;/EnableSingleFileAnalyzer&gt;</value>
<comment>{StrBegin="NETSDK1211: "}</comment>
</data>
<!-- The latest message added is EnableSingleFileAnalyzerUnsupported. Please update this value with each PR to catch parallel PRs both adding a new message -->
</root>
28 changes: 23 additions & 5 deletions src/Tasks/Common/Resources/xlf/Strings.cs.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 23 additions & 5 deletions src/Tasks/Common/Resources/xlf/Strings.de.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 23 additions & 5 deletions src/Tasks/Common/Resources/xlf/Strings.es.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading