Fix single-file static web assets tests #34186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-AspNetCore
|
Thanks for your PR, @sbomer. |
javiercn
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes test bugs in two tests, that are blocking #34077.
These tests were calling
Execute($"/p:PublishSingleFile=true /p:RuntimeIdentifier={RuntimeInformation.RuntimeIdentifier}"), which was setting the value ofPublishSingleFiletotrue /p:RuntimeIdentifier=<RID>. The two MSBuild properties should have been passed as separate arguments toExecute.This was resulting in the tests not actually publishing single-file, and not setting the RID. Fixing this required updating the tests to expect RID-specific static web assets. The expected manifests were then updated by running the
update-test-baselines.ps1script.