Skip to content

Simplify scenario-tests test invocation & define dependencies #41055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2024
Merged

Simplify scenario-tests test invocation & define dependencies #41055

merged 3 commits into from
May 21, 2024

Conversation

ViktorHofer
Copy link
Member

  1. Simplify scenario-tests test invocation by avoiding the intermediate NoTargets wrapper project.
  2. Declare the dependency on extract-sdk-archive.proj in the test projects directly to avoid race conditions. [main] Update dependencies from dotnet/runtime #41014 failed because the scenario-tests already ran but the SDK test folder wasn't yet ready.

@ViktorHofer
Simplify scenario-tests test invocation & define dependencies
dec5515 
1. Simplify scenario-tests test invocation by avoiding
   the intermediate NoTargets wrapper project.
2. Declare the dependency on extract-sdk-archive.proj
   in the test projects directly to avoid race
   conditions. #41014
   failed because the scenario-tests already ran
   but the SDK test folder wasn't yet ready.
@ViktorHofer ViktorHofer self-assigned this May 21, 2024
@ViktorHofer ViktorHofer requested review from a team as code owners May 21, 2024 13:28
@ghost ghost added the untriaged Request triage from a team member label May 21, 2024
mthalman
mthalman reviewed May 21, 2024
View reviewed changes
@ViktorHofer ViktorHofer enabled auto-merge (squash) May 21, 2024 15:43
@ViktorHofer ViktorHofer merged commit a4787a0 into main May 21, 2024
@ViktorHofer ViktorHofer deleted the SimplifyScenarioTestsAndDefineDependency branch May 21, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthalman mthalman mthalman approved these changes

Assignees

@ViktorHofer ViktorHofer

Labels
Area-VMR untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ViktorHofer @mthalman