Remove repo level SB legs in CI and PR validation #45765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
NikolaMilosavljevic
approved these changes
Jan 7, 2025
mthalman
approved these changes
Jan 7, 2025
ViktorHofer
approved these changes
Jan 7, 2025
This was referenced Jan 8, 2025
Open
|
Merging on red, failing legs are unrelated. |
|
This causes a regression on repos that consume the SB intermediates of the sdk repo: dotnet/runtime#111328 (comment). |
mthalman
added a commit
to mthalman/sdk
that referenced
this pull request
Jan 24, 2025
…)" This reverts commit cc260aa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These do not add value since the SDK repo has a leg that validates the full source build of the VMR. The SB legs are just wasting compute and are a source of noise in regards to falsely detected prebuilts.
As part of this work, I also removed the prebuilt baseline. While this file may be useful when doing a local
./build.sh -sb, it will quickly become stale and not kept up-to-date. I believe it is best to remove it so that./build.sh -sbwould report all locally detected prebuilts however many are false positives.