Skip to content

[StaticWebAssets] Optimize compression #47734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 21, 2025
Merged

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented Mar 19, 2025

@ghost ghost added Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member labels Mar 19, 2025
Copy link
Contributor

Thanks for your PR, @javiercn.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

@javiercn javiercn force-pushed the javiercn/optimize-compression branch from 6b67c1e to 37dfb54 Compare April 2, 2025 18:08
@javiercn javiercn force-pushed the javiercn/optimize-compression branch from e05f454 to 2cca5f1 Compare April 3, 2025 10:31
@javiercn javiercn marked this pull request as ready for review April 3, 2025 11:27
@Copilot Copilot AI review requested due to automatic review settings April 3, 2025 11:27
@javiercn javiercn requested review from a team and vijayrkn as code owners April 3, 2025 11:27
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 77 out of 97 changed files in this pull request and generated no comments.

Files not reviewed (20)
  • src/StaticWebAssetsSdk/Targets/Microsoft.NET.Sdk.StaticWebAssets.Compression.targets: Language not supported
  • src/StaticWebAssetsSdk/Targets/Microsoft.NET.Sdk.StaticWebAssets.JSModules.targets: Language not supported
  • src/StaticWebAssetsSdk/Targets/Microsoft.NET.Sdk.StaticWebAssets.targets: Language not supported
  • src/WebSdk/Web/Targets/Sdk.Server.props: Language not supported
  • test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/StaticWebAssetsBaselines/JSModules_ManifestIncludesModuleTargetPaths.Build.staticwebassets.json: Language not supported
  • test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/StaticWebAssetsBaselines/JsModules_Hosted_CanCustomizeBlazorInitialization.Publish.files.json: Language not supported
  • test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/StaticWebAssetsBaselines/JsModules_Hosted_CanCustomizeBlazorInitialization.Publish.staticwebassets.json: Language not supported
  • test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/StaticWebAssetsBaselines/Publish60Hosted_Works.Publish.staticwebassets.json: Language not supported
  • test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/StaticWebAssetsBaselines/StaticWebAssets_BackCompatibilityPublish_Hosted_Works.Publish.staticwebassets.json: Language not supported
  • test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/StaticWebAssetsBaselines/StaticWebAssets_Build_Hosted_Works.Build.staticwebassets.json: Language not supported
  • test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/StaticWebAssetsBaselines/StaticWebAssets_HostedApp_ReferencingNetStandardLibrary_Works.Build.staticwebassets.json: Language not supported
  • test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/StaticWebAssetsBaselines/StaticWebAssets_Publish_DoesNotIncludeXmlDocumentationFiles_AsAssets.Publish.staticwebassets.json: Language not supported
  • test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/StaticWebAssetsBaselines/StaticWebAssets_Publish_Hosted_Works.Publish.staticwebassets.json: Language not supported
  • test/Microsoft.NET.Sdk.Razor.Tests/StaticWebAssetsBaselines/BuildProjectWithReferences_CorrectlyBundlesScopedCssFiles.Build.files.json: Language not supported
  • test/Microsoft.NET.Sdk.Razor.Tests/StaticWebAssetsBaselines/BuildProjectWithReferences_CorrectlyBundlesScopedCssFiles.Build.staticwebassets.json: Language not supported
  • test/Microsoft.NET.Sdk.Razor.Tests/StaticWebAssetsBaselines/BuildProjectWithReferences_DeployOnBuild_GeneratesPublishJsonManifestAndCopiesPublishAssets.Build.staticwebassets.json: Language not supported
  • test/Microsoft.NET.Sdk.Razor.Tests/StaticWebAssetsBaselines/BuildProjectWithReferences_DeployOnBuild_GeneratesPublishJsonManifestAndCopiesPublishAssets.Publish.files.json: Language not supported
  • test/Microsoft.NET.Sdk.Razor.Tests/StaticWebAssetsBaselines/BuildProjectWithReferences_DeployOnBuild_GeneratesPublishJsonManifestAndCopiesPublishAssets.Publish.staticwebassets.json: Language not supported
  • test/Microsoft.NET.Sdk.Razor.Tests/StaticWebAssetsBaselines/BuildProjectWithReferences_GeneratesJsonManifestAndCopiesItToOutputFolder.Build.files.json: Language not supported
  • test/Microsoft.NET.Sdk.Razor.Tests/StaticWebAssetsBaselines/BuildProjectWithReferences_GeneratesJsonManifestAndCopiesItToOutputFolder.Build.staticwebassets.json: Language not supported

@javiercn javiercn requested a review from MackinnonBuck April 3, 2025 14:18
@javiercn javiercn force-pushed the javiercn/optimize-compression branch from 2060a82 to c02d24f Compare April 4, 2025 09:25
@javiercn javiercn merged commit 2106da3 into main Apr 21, 2025
39 checks passed
@javiercn javiercn deleted the javiercn/optimize-compression branch April 21, 2025 20:21
javiercn added a commit that referenced this pull request Apr 22, 2025
* Fix issue where publish compression was disabled when build compression was disabled
* Support passing a custom compression level with BrotliCompressionLevel
* Compress only current project assets for Razor Class Libraries and compress assets missing compression on Web and Blazor scenarios.
* Support disabling compression for discovered assets (stuff in the wwwroot folder)
* Create endpoints for package assets without endpoints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants