[release/9.0.3xx] Update dependencies from dotnet/msbuild

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/msbuild

• Subscription: 5e4cfc1f-38c1-4a4d-b498-47112be4b03f
• Build: 20250407.8
• Date Produced: April 7, 2025 10:06:40 AM UTC
• Commit: fc19b05155b893f7f77eddf1fb53e6646b53d51a
• Branch: refs/heads/vs17.14

• Updates:
  • Microsoft.SourceBuild.Intermediate.msbuild: from 17.14.0-preview-25177-05 to 17.14.4-preview-25207-08
  • Microsoft.Build: from 17.14.0-preview-25177-05 to 17.14.4
  • Microsoft.Build.Localization: from 17.14.0-preview-25177-05 to 17.14.4-preview-25207-08

[ViktorHofer]

The failures look related. cc @carlossanlop @rainersigwald

[Forgind]

I'm seeing:

obj\Debug\net9.0\staticwebassets.build.json : error : MissingMethodException: Method not found: '!!0 System.Text.Json.JsonSerializer.Deserialize(System.ReadOnlySpan`1<Byte>, System.Text.Json.Serialization.Metadata.JsonTypeInfo`1<!!0>)'. [C:\h\w\9B43088E\t\dotnetSdkTests\0o2fvlya.ets\ItCanRunAnApp---11F653B3\ItCanRunAnApp---11F653B3.csproj]

I saw ViktorHofer assigned you, @carlossanlop, are you handling this?

[carlossanlop]

The System.Text.Json error does not look familiar or related to the changes we've been making in maintenance-packages. @rainersigwald do you know if the changes from maintenance-packages merged in main in msbuild are being flowed into this 9.0.3xx branch?

I also see a warning stating that netcoreapp2.1 is out of support but I don't think we're treating warnings as errors.

warning NETSDK1138: The target framework 'netcoreapp2.1' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy. 

[rainersigwald]

both main and 9.0.3xx builds should have the maintenance-packages changes reverted at the moment.

[akoeplinger]

The latest commit contains the maintenance-packages changes again. We're seeing the same issue in #48212

[Forgind]

Can you link to the pr(s) to revert the updates? I see dotnet/msbuild#11684 as making them, and I don't see anything reverting that

[ViktorHofer]

@carlossanlop now that the work in #48034 is completed, can you please take a look at this dependency flow for 9.0.3xx? I assume we need to backport a subset of the changes done in the runtime PR.

[carlossanlop]

The latest maestro update included @rainersigwald 's change in this flow: dotnet/msbuild#11677

There are test failures. I'm investigating.

[carlossanlop]

I see failures only in the FullFramework tests job: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1008785&view=logs&j=b69c0128-beae-536a-0344-1c918351dbc7&t=60696cef-0589-543b-3dbb-b76b5b65d586&l=334

One failure is can't find Microsoft.CodeAnalysis.Razor.Compiler Version 9.0.0.0:

• Log: https://helixr1107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-sdk-refs-pull-48005-merge-ed79a7313f2c484984/EndToEnd.Tests.dll/3/console.c409a975.log?helixlogtype=result
• Output:

[xUnit.net 00:08:40.74]     EndToEnd.Tests.ProjectBuildTests.ItCanRunAnAppUsingTheWebSdk [OUTPUT] 》CSC : warning CS8032: An instance of analyzer Microsoft.CodeAnalysis.Razor.Compiler.Analyzers.ComponentParameterNullableWarningSuppressor cannot be created from C:\h\w\B05809B5\p\d\sdk\9.0.300-ci\Sdks\Microsoft.NET.Sdk.Razor\source-generators\Microsoft.CodeAnalysis.Razor.Compiler.dll : Method 'get_SupportedSuppressions' in type 'Microsoft.CodeAnalysis.Razor.Compiler.Analyzers.ComponentParameterNullableWarningSuppressor' from assembly 'Microsoft.CodeAnalysis.Razor.Compiler, Version=9.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60' does not have an implementation.. [C:\h\w\B05809B5\t\dotnetSdkTests\4hzcddrc.4kn\ItCanRunAnApp---11F653B3\ItCanRunAnApp---11F653B3.csproj]
[xUnit.net 00:08:40.74]     EndToEnd.Tests.ProjectBuildTests.ItCanRunAnAppUsingTheWebSdk [OUTPUT] 》CSC : warning CS8784: Generator 'RazorSourceGenerator' failed to initialize. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'MissingMethodException' with message 'Method not found: 'Microsoft.CodeAnalysis.IncrementalValueProvider`1<System.Collections.Immutable.ImmutableArray`1<!!0>> Microsoft.CodeAnalysis.IncrementalValueProviderExtensions.Collect(Microsoft.CodeAnalysis.IncrementalValuesProvider`1<!!0>)'.'. [C:\h\w\B05809B5\t\dotnetSdkTests\4hzcddrc.4kn\ItCanRunAnApp---11F653B3\ItCanRunAnApp---11F653B3.csproj]

Another failure is can't find System.Text.Json methods, both are methods that use span as arguments, so it could be related to System.Memory. Found two variants:

• Log: https://helixr1107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-sdk-refs-pull-48005-merge-ed79a7313f2c484984/dotnet.Tests.dll.12/3/console.bde693f9.log?helixlogtype=result
• Output:

SDK Resolver Failure: "The SDK resolver "Microsoft.DotNet.MSBuildSdkResolver" failed while attempting to resolve the SDK "Microsoft.VisualStudio.JavaScript.SDK/1.0.1948920". Exception: "System.MissingMethodException: Method not found: 'Void System.Text.Json.Utf8JsonReader..ctor(System.ReadOnlySpan`1<Byte>, Boolean, System.Text.Json.JsonReaderState)'.

and

• Log: https://helixr1107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-sdk-refs-pull-48005-merge-ed79a7313f2c484984/Microsoft.NET.Publish.Tests.dll.3/3/console.eac2308f.log?helixlogtype=result
• Output:

[xUnit.net 00:05:07.74]     Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishASingleFileApp.Target_after_AfterSdkPublish_executes(sdk: "Microsoft.NET.Sdk.Web") [OUTPUT] 》CSC : warning CS8784: Generator 'RazorSourceGenerator' failed to initialize. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'MissingMethodException' with message 'Method not found: 'Microsoft.CodeAnalysis.IncrementalValueProvider`1<System.Collections.Immutable.ImmutableArray`1<!!0>> Microsoft.CodeAnalysis.IncrementalValueProviderExtensions.Collect(Microsoft.CodeAnalysis.IncrementalValuesProvider`1<!!0>)'.'. [C:\h\w\B05809B5\t\dotnetSdkTests\y44sxjci.zid\Target_after_---F4B0511B\HelloWorldWithSubDirs.csproj]

[carlossanlop]

I pushed a commit for these two tasks so they are forced to consume the toolset version of System.Text.Json like they do in main:

• src/RazorSdk/Tasks/Microsoft.NET.Sdk.Razor.Tasks.csproj
• src/StaticWebAssetsSdk/Tasks/Microsoft.NET.Sdk.StaticWebAssets.Tasks.csproj

[carlossanlop]

@v-wuzhai the 2nd failure from my comment above looks related to the commit you pushed 728a9c6 maybe we should revert that?

[ericstj]

Are we sure these are running on a VS that has the updated MSBuild and bindingRedirects? What ensures that?

[rainersigwald]

Are we sure these are running on a VS that has the updated MSBuild and bindingRedirects? What ensures that?

The tests are on an MSBuild/VS that lags, and that's fairly intentional.

[rainersigwald]

@dsplaisted I (manually) backported your 9cf989b to unstick this.

[marcpopMSFT]

In main, this reference is in a netframework conditioned itemgroup. Should it be here as well?

[rainersigwald]

I don't think it matters much since this should get dropped on core but might as well make the merge as easy as possible.