Skip to content

Remove dotnet-benchview group #49787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DrewScoggins
Copy link
Member

This is an old variable group that is no longer in use.

This is an old variable group that is no longer in use.
@DrewScoggins DrewScoggins requested a review from marcpopMSFT July 15, 2025 19:12
@DrewScoggins
Copy link
Member Author

DrewScoggins commented Jul 15, 2025

@DrewScoggins DrewScoggins requested a review from dsplaisted July 15, 2025 19:18
@dsplaisted
Copy link
Member

Does this mean these legs weren't running, and now will be? Or what?

@DrewScoggins
Copy link
Member Author

This variable group had sas keys to access our storage accounts. To be honest, I am not sure why they were ever here. I don't know of any performance testing that happened as part of the build of SDK, and it seems unlikely we were uploading anything. Also, these sas keys have not been valid for at least a couple weeks, if not longer. We want to be able to delete these variable groups out of AzDO, but can't until we get rid of all of the references.

@dsplaisted
Copy link
Member

@nagilson @baronfel Should we merge on red for these or are we going to backport disabling the container tests to the 8.0 branches?

@DrewScoggins DrewScoggins enabled auto-merge August 5, 2025 21:31
@DrewScoggins
Copy link
Member Author

@dsplaisted Are we good to merge on the failures? Also can you please approve the other two branches?

@DrewScoggins DrewScoggins merged commit 6203477 into dotnet:release/8.0.1xx Aug 5, 2025
17 of 18 checks passed
@dsplaisted
Copy link
Member

@DrewScoggins I've merged the other two PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants