Disable static graph restore for file-based apps #50245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR disables static graph restore for file-based apps to resolve issue #49876. The change prevents MSBuild from using static graph evaluation during restore operations for C# files that are run directly without a project file.
- Adds
RestoreUseStaticGraphEvaluation>falseproperty to virtual project files generated for file-based apps - Includes test coverage for both implicit and explicit static graph restore scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs | Adds property to disable static graph evaluation in generated virtual project files |
| test/dotnet.Tests/CommandTests/Run/RunFileTests.cs | Adds tests to verify static graph restore behavior and updates existing test project templates |
333fred
reviewed
Aug 14, 2025
| @@ -891,6 +891,7 @@ public static void WriteProjectFile( | |||
| writer.WriteLine(""" | |||
| <EnableDefaultCompileItems>false</EnableDefaultCompileItems> | |||
| <DisableDefaultItemsInProjectFolder>true</DisableDefaultItemsInProjectFolder> | |||
| <RestoreUseStaticGraphEvaluation>false</RestoreUseStaticGraphEvaluation> | |||
There was a problem hiding this comment.
Should we try looking through the property directives and seeing if any of them are an explicit enable of static graph, and give a more reasonable error if so? Or is it too niche?
MiYanni
approved these changes
Aug 14, 2025
chsienki
approved these changes
Aug 14, 2025
333fred
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49876.